[GitHub] alerman commented on a change in pull request #524: Tiered Volume Chooser, including Regex and Default strategies.

[GitBox <gi...@apache.org>]

alerman commented on a change in pull request #524: Tiered Volume Chooser, including Regex and Default strategies.
URL: https://github.com/apache/accumulo/pull/524#discussion_r194010938
 
 

 ##########
 File path: server/base/src/main/java/org/apache/accumulo/server/fs/TieredStorageStrategy.java
 ##########
 @@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.accumulo.server.fs;
+
+import org.apache.accumulo.server.conf.ServerConfigurationFactory;
+
+public interface TieredStorageStrategy {
+  public String getVolumeList(VolumeChooserEnvironment vce, ServerConfigurationFactory confFactory,
 
 Review comment:
   The idea here was to give the user more flexibility. I created the regex strategy mostly for testing, but figured I would leave it in as I could see its use. There are scenario's that we may not know about that a user could create there own strategy. One example would be choosing volumes based on a date range within the key. (Eg, if the key is within X days of today, volume a. If its within Y days, volume b. Else, volume c).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services