You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/01/08 08:26:12 UTC

[GitHub] [incubator-iceberg] chenjunjiedada commented on a change in pull request #721: Add PreferredLocations support for Iceberg Spark Source

chenjunjiedada commented on a change in pull request #721: Add PreferredLocations support for Iceberg Spark Source
URL: https://github.com/apache/incubator-iceberg/pull/721#discussion_r364109948
 
 

 ##########
 File path: spark/src/main/java/org/apache/iceberg/spark/source/Reader.java
 ##########
 @@ -287,19 +309,21 @@ public String toString() {
     private final Broadcast<FileIO> io;
     private final Broadcast<EncryptionManager> encryptionManager;
     private final boolean caseSensitive;
+    private final boolean enableLocality;
 
 Review comment:
   How about LocalitySensitive or LocalityAwareness? Just a thought from `caseSensitive`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org