You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Kousuke Saruta (Code Review)" <ge...@cloudera.org> on 2016/11/23 09:09:30 UTC
[kudu-CR] For the first time of building bitshuffle, `rm bitshuffle.a` will return an exit code 1 and the build will fail because "-e" option is set in build-thirdparty.sh. bitshuffle.a should be removed only when it exists.
Kousuke Saruta has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5199
Change subject: For the first time of building bitshuffle, `rm bitshuffle.a` will return an exit code 1 and the build will fail because "-e" option is set in build-thirdparty.sh. bitshuffle.a should be removed only when it exists.
......................................................................
For the first time of building bitshuffle, `rm bitshuffle.a` will return an exit code 1 and the build will fail because "-e" option is set in build-thirdparty.sh.
bitshuffle.a should be removed only when it exists.
Change-Id: I722bace0d784c35e1099d65b67091c5c3d51e46b
---
M thirdparty/build-definitions.sh
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/5199/1
--
To view, visit http://gerrit.cloudera.org:8080/5199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I722bace0d784c35e1099d65b67091c5c3d51e46b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Kousuke Saruta <sa...@oss.nttdata.co.jp>
[kudu-CR] For the first time of building bitshuffle, `rm bitshuffle.a` will return an exit code 1 and the build will fail because "-e" option is set in build-thirdparty.sh. bitshuffle.a should be removed only when it exists.
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: For the first time of building bitshuffle, `rm bitshuffle.a` will return an exit code 1 and the build will fail because "-e" option is set in build-thirdparty.sh. bitshuffle.a should be removed only when it exists.
......................................................................
Patch Set 1:
Thanks for the patch, but an equivalent fix has already been merged: http://gerrit.cloudera.org:8080/5196
--
To view, visit http://gerrit.cloudera.org:8080/5199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I722bace0d784c35e1099d65b67091c5c3d51e46b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] For the first time of building bitshuffle, `rm bitshuffle.a` will return an exit code 1 and the build will fail because "-e" option is set in build-thirdparty.sh. bitshuffle.a should be removed only when it exists.
Posted by "Kousuke Saruta (Code Review)" <ge...@cloudera.org>.
Kousuke Saruta has abandoned this change.
Change subject: For the first time of building bitshuffle, `rm bitshuffle.a` will return an exit code 1 and the build will fail because "-e" option is set in build-thirdparty.sh. bitshuffle.a should be removed only when it exists.
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/5199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I722bace0d784c35e1099d65b67091c5c3d51e46b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] For the first time of building bitshuffle, `rm bitshuffle.a` will return an exit code 1 and the build will fail because "-e" option is set in build-thirdparty.sh. bitshuffle.a should be removed only when it exists.
Posted by "Kousuke Saruta (Code Review)" <ge...@cloudera.org>.
Kousuke Saruta has posted comments on this change.
Change subject: For the first time of building bitshuffle, `rm bitshuffle.a` will return an exit code 1 and the build will fail because "-e" option is set in build-thirdparty.sh. bitshuffle.a should be removed only when it exists.
......................................................................
Patch Set 1:
Oh I see. I'll close this issue.
--
To view, visit http://gerrit.cloudera.org:8080/5199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I722bace0d784c35e1099d65b67091c5c3d51e46b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No