You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2016/07/08 07:02:20 UTC
[GitHub] storm pull request #1545: STORM-1950 Change response json of "Topology Lag" ...
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1545
STORM-1950 Change response json of "Topology Lag" REST API to keyed by spoutId, topic, partition
* bin/storm-kafka-monitor: guard classpath to only uses storm-kafka-monitor*.jar
* KafkaOffsetLagUtil: when succeed to get, output is keyed by topic and partition
* TopologySpoutLag: modify JSON response keyed by spoutId
* reflect changes on topology page
Here's sample JSON response from /lag API
```
{
"kafka-spout":{
"spoutLagResult":{
"myKafkaTopic":{
"0":{
"consumerCommittedOffset":749491,
"logHeadOffset":911511,
"lag":162020
},
"1":{
"consumerCommittedOffset":1168,
"logHeadOffset":1168,
"lag":0
},
"2":{
"consumerCommittedOffset":159339,
"logHeadOffset":159339,
"lag":0
}
}
},
"spoutId":"kafka-spout",
"spoutType":"KAFKA"
}
}
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-1950
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1545.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1545
----
commit e3e26daec8e1d57bc87343807df74acf6626eb5f
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-07-08T06:07:05Z
STORM-1950 Change response json of "Topology Lag" REST API to keyed by spoutId, topic, partition
* bin/storm-kafka-monitor: guard classpath to only uses storm-kafka-monitor*.jar
* KafkaOffsetLagUtil: when succeed to get, output is keyed by topic and partition
* TopologySpoutLag: modify JSON response keyed by spoutId
* reflect changes on topology page
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1545: STORM-1950 Change response json of "Topology Lag" REST AP...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1545
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1545: STORM-1950 Change response json of "Topology Lag" ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1545
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1545: STORM-1950 Change response json of "Topology Lag" REST AP...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1545
Actually I created branch for 1.x, but since the diff is same, I don't create individual pull request for 1.x.
I guess we can just cherry-pick to port back.
Please let me know if anyone think having PR for 1.x branch is easy for reviewing and merging. I'll create it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---