You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by ravipesala <gi...@git.apache.org> on 2017/09/10 08:57:57 UTC
[GitHub] carbondata pull request #1345: Replace BigDecimal to double to improve perfo...
GitHub user ravipesala opened a pull request:
https://github.com/apache/carbondata/pull/1345
Replace BigDecimal to double to improve performance
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ravipesala/incubator-carbondata adaptive-encode-perf
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1345.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1345
----
commit 59e215260dc307896bdda8945c5f4e634c3ad083
Author: Ravindra Pesala <ra...@gmail.com>
Date: 2017-09-10T08:51:15Z
Replace Bigdecimal to double to improve performance
----
---
[GitHub] carbondata pull request #1345: [CARBONDATA-1471] Replace BigDecimal to doubl...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1345#discussion_r138514001
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveFloatingCodec.java ---
@@ -98,12 +97,11 @@ protected ColumnPageEncoderMeta getEncoderMeta(ColumnPage inputPage) {
public ColumnPageDecoder createDecoder(ColumnPageEncoderMeta meta) {
assert meta instanceof AdaptiveFloatingEncoderMeta;
AdaptiveFloatingEncoderMeta codecMeta = (AdaptiveFloatingEncoderMeta) meta;
- final Compressor compressor = CompressorFactory.getInstance().getCompressor(
- codecMeta.getCompressorName());
+ final Compressor compressor =
+ CompressorFactory.getInstance().getCompressor(codecMeta.getCompressorName());
final DataType targetDataType = codecMeta.getTargetDataType();
return new ColumnPageDecoder() {
- @Override
- public ColumnPage decode(byte[] input, int offset, int length)
+ @Override public ColumnPage decode(byte[] input, int offset, int length)
--- End diff --
move `@Override` to previous line
---
[GitHub] carbondata issue #1345: [CARBONDATA-1471] Replace BigDecimal to double to im...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1345
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5/
---
[GitHub] carbondata issue #1345: [CARBONDATA-1471] Replace BigDecimal to double to im...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1345
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/705/
---
[GitHub] carbondata issue #1345: [CARBONDATA-1471] Replace BigDecimal to double to im...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1345
retest this please
---
[GitHub] carbondata pull request #1345: [CARBONDATA-1471] Replace BigDecimal to doubl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1345
---
[GitHub] carbondata pull request #1345: [CARBONDATA-1471] Replace BigDecimal to doubl...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1345#discussion_r138515278
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveFloatingCodec.java ---
@@ -98,12 +97,11 @@ protected ColumnPageEncoderMeta getEncoderMeta(ColumnPage inputPage) {
public ColumnPageDecoder createDecoder(ColumnPageEncoderMeta meta) {
assert meta instanceof AdaptiveFloatingEncoderMeta;
AdaptiveFloatingEncoderMeta codecMeta = (AdaptiveFloatingEncoderMeta) meta;
- final Compressor compressor = CompressorFactory.getInstance().getCompressor(
- codecMeta.getCompressorName());
+ final Compressor compressor =
+ CompressorFactory.getInstance().getCompressor(codecMeta.getCompressorName());
final DataType targetDataType = codecMeta.getTargetDataType();
return new ColumnPageDecoder() {
- @Override
- public ColumnPage decode(byte[] input, int offset, int length)
+ @Override public ColumnPage decode(byte[] input, int offset, int length)
--- End diff --
ok
---
[GitHub] carbondata issue #1345: Replace BigDecimal to double to improve performance
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1345
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/644/
---
[GitHub] carbondata pull request #1345: [CARBONDATA-1471] Replace BigDecimal to doubl...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1345#discussion_r138514170
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveFloatingCodec.java ---
@@ -211,24 +199,23 @@ public long decodeLong(int value) {
throw new RuntimeException("internal error: " + debugInfo());
}
- @Override
- public double decodeDouble(byte value) {
- return BigDecimal.valueOf(value).divide(factor).doubleValue();
+ @Override public double decodeDouble(byte value) {
--- End diff --
move @Override to previous line
---
[GitHub] carbondata issue #1345: Replace BigDecimal to double to improve performance
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1345
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/659/
---
[GitHub] carbondata issue #1345: [CARBONDATA-1471] Replace BigDecimal to double to im...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1345
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/720/
---
[GitHub] carbondata issue #1345: [CARBONDATA-1471] Replace BigDecimal to double to im...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1345
LGTM
---
[GitHub] carbondata issue #1345: Replace BigDecimal to double to improve performance
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1345
retest this please
---