[GitHub] [airflow] sti0 commented on a change in pull request #13536: Fix string encoding in DockerOperator when using xcom / json

[GitBox <gi...@apache.org>]

sti0 commented on a change in pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#discussion_r555268657



##########
File path: tests/providers/docker/operators/test_docker.py
##########
@@ -244,7 +244,7 @@ def test_execute_xcom_behavior(self):
         xcom_push_result = xcom_push_operator.execute(None)
         no_xcom_push_result = no_xcom_push_operator.execute(None)
 
-        self.assertEqual(xcom_push_result, b'container log')
+        self.assertEqual(xcom_push_result, 'container log')

Review comment:
       Maybe it's possible to look if [pickling](https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#enable-xcom-pickling)  is activated and then return a byte object, otherwise a string. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org