You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/10/22 18:22:29 UTC

[GitHub] [samza] Zhangyx39 opened a new pull request #1435: SAMZA-2596: Replace String.format() calls to avoid MissingFormatArgumentException

Zhangyx39 opened a new pull request #1435:
URL: https://github.com/apache/samza/pull/1435


   Symptom: String.format("..." + key) would through MissingFormatArgumentException if the key string contains something like "%3A" or "%d". And original exception would be hidden by this new exception.
    
   Cause: We have no control on what the key can be. Should avoid using String.format().
    
   Changes: Simply remove the String.format() should be enough.
    
   Tests: No test since it's a minor change.
   
   API Changes: No API change.
   
   Upgrade Instructions: No backward-compatibility issue. No need to upgrade.
   
   Usage Instructions: User won't use this code directly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] Zhangyx39 commented on pull request #1435: SAMZA-2596: Replace String.format() calls to avoid MissingFormatArgumentException

Posted by GitBox <gi...@apache.org>.
Zhangyx39 commented on pull request #1435:
URL: https://github.com/apache/samza/pull/1435#issuecomment-718255598


   @lakshmi-manasa-g Thanks for the review!
   1. They are not related to this change. I saw some warnings on IDE about them. So I updated as well. These changes should have no effect.
   2. We only had this issue in table API. Good suggestion. Also updated for CachingTable.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] sborya merged pull request #1435: SAMZA-2596: Replace String.format() calls to avoid MissingFormatArgumentException

Posted by GitBox <gi...@apache.org>.
sborya merged pull request #1435:
URL: https://github.com/apache/samza/pull/1435


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org