You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@bahir.apache.org by chermenin <gi...@git.apache.org> on 2017/12/01 14:41:11 UTC
[GitHub] bahir-flink pull request #24: Improved integration test cases
GitHub user chermenin opened a pull request:
https://github.com/apache/bahir-flink/pull/24
Improved integration test cases
This PR is intended to fix periodically unstable test method `testUnboundedPojoStreamSimplePatternMatch` in the integration test cases for `flink-library-siddhi`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chermenin/bahir-flink it_case_fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bahir-flink/pull/24.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #24
----
commit dbb9f48a5453e08f78a4e5beae3ca987b720c884
Author: Aleksandr Chermenin <al...@epam.com>
Date: 2017-12-01T14:09:34Z
Improved integration test cases
----
---
[GitHub] bahir-flink issue #24: Improved integration test cases for flink-library-sid...
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/bahir-flink/pull/24
@chermenin please just keep this one to ensure your own contribution merged firstly.
---
[GitHub] bahir-flink issue #24: Improved integration test cases for flink-library-sid...
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/bahir-flink/pull/24
LGTM, the fix helps improve test case stability.
---
[GitHub] bahir-flink pull request #24: Improved integration test cases for flink-libr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/bahir-flink/pull/24
---
[GitHub] bahir-flink issue #24: Improved integration test cases for flink-library-sid...
Posted by chermenin <gi...@git.apache.org>.
Github user chermenin commented on the issue:
https://github.com/apache/bahir-flink/pull/24
@haoch I saw that you added my commits to your other pull request. Is it needed to close this one or it can just stay here?
---
[GitHub] bahir-flink issue #24: Improved integration test cases for flink-library-sid...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/bahir-flink/pull/24
I've filed https://issues.apache.org/jira/browse/BAHIR-156 to have a JIRA id for this issue.
I'll now merge the PR
---
[GitHub] bahir-flink issue #24: Improved integration test cases for flink-library-sid...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/bahir-flink/pull/24
Thanks a lot for improving the tests stability.
I'll review the PR and the merge it :)
---
[GitHub] bahir-flink issue #24: Improved integration test cases for flink-library-sid...
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/bahir-flink/pull/24
@rmetzger could you please help review the fix?
---