You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "vttranlina (via GitHub)" <gi...@apache.org> on 2023/08/18 02:04:48 UTC
[GitHub] [james-project] vttranlina opened a new pull request, #1689: Fix jvm-*.options when upgrade Docker Cassandra 3 -> 4...
vttranlina opened a new pull request, #1689:
URL: https://github.com/apache/james-project/pull/1689
Time to start up the Cassandra container on my pc
Before: 67 seconds
After: 13 seconds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on a diff in pull request #1689: Fix jvm-*.options when upgrade Docker Cassandra 3 -> 4...
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on code in PR #1689:
URL: https://github.com/apache/james-project/pull/1689#discussion_r1302373521
##########
backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/CassandraCluster.java:
##########
@@ -64,7 +66,12 @@ private CassandraCluster(CassandraModule module, Host host) throws RuntimeExcept
.keyspace(KEYSPACE)
.replicationFactor(1)
.disableDurableWrites();
- this.nonPrivilegedCluster = ClusterFactory.create(clusterConfiguration, keyspaceConfiguration);
+
+ DriverConfigLoader driverConfigLoader = DriverConfigLoader.programmaticBuilder()
+ .withString(DefaultDriverOption.SESSION_LEAK_THRESHOLD, "16")
Review Comment:
Why do we have that many session actives and does it affect perf/stability? I find a bit easy to just silence it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on a diff in pull request #1689: Fix jvm-*.options when upgrade Docker Cassandra 3 -> 4...
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on code in PR #1689:
URL: https://github.com/apache/james-project/pull/1689#discussion_r1302760222
##########
backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/DockerCassandra.java:
##########
@@ -169,14 +169,21 @@ public void onComplete() {
public void close() {
}
});
+
+ String memorySettingCommand = Optional.ofNullable(System.getenv("CI"))
Review Comment:
Shouldn't we add this somewhere for the CI then? Like maybe the Jenkinsfile?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on a diff in pull request #1689: Fix jvm-*.options when upgrade Docker Cassandra 3 -> 4...
Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on code in PR #1689:
URL: https://github.com/apache/james-project/pull/1689#discussion_r1302376117
##########
backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/CassandraCluster.java:
##########
@@ -64,7 +66,12 @@ private CassandraCluster(CassandraModule module, Host host) throws RuntimeExcept
.keyspace(KEYSPACE)
.replicationFactor(1)
.disableDurableWrites();
- this.nonPrivilegedCluster = ClusterFactory.create(clusterConfiguration, keyspaceConfiguration);
+
+ DriverConfigLoader driverConfigLoader = DriverConfigLoader.programmaticBuilder()
+ .withString(DefaultDriverOption.SESSION_LEAK_THRESHOLD, "16")
Review Comment:
> Why do we have that many session actives and does it affect perf/stability
I find a test creates a new session for each test and not close to it, I think we have more similarities somewhere
When I read a log from `test-run.log` of the fail test case, I see a suspect warning
```
21:08:37.630 [WARN ] c.d.o.d.i.c.session.DefaultSession - You have too many session instances: 10 active, expected less than 4 (see 'advanced.session-leak.threshold' in the configuration)
21:08:37.981 [WARN ] c.d.o.d.i.c.session.DefaultSession - You have too many session instances: 11 active, expected less than 4 (see 'advanced.session-leak.threshold' in the configuration)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on pull request #1689: Fix jvm-*.options when upgrade Docker Cassandra 3 -> 4...
Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on PR #1689:
URL: https://github.com/apache/james-project/pull/1689#issuecomment-1689258958
CI fail
```
targetFolderNamesShouldWorkWhenTargetFolderDoNotExist(File) – org.apache.james.mailets.WithStorageDirectiveIntegrationTest
1m 3s
Error
Condition with lambda expression in org.apache.james.utils.TestIMAPClient was not fulfilled within 1 minutes.
Stacktrace
org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in org.apache.james.utils.TestIMAPClient was not fulfilled within 1 minutes.
```
it looks not related to this pr, can you re-run the ci?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] quantranhong1999 commented on pull request #1689: Fix jvm-*.options when upgrade Docker Cassandra 3 -> 4...
Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 commented on PR #1689:
URL: https://github.com/apache/james-project/pull/1689#issuecomment-1687793011
> but for the CI probably better to use more
Maybe we could set an env variable for CI env acknowledge, and default to local env?
rf: https://github.com/apache/james-project/blob/master/Jenkinsfile#L39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on a diff in pull request #1689: Fix jvm-*.options when upgrade Docker Cassandra 3 -> 4...
Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on code in PR #1689:
URL: https://github.com/apache/james-project/pull/1689#discussion_r1302755764
##########
backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/CassandraCluster.java:
##########
@@ -64,7 +66,12 @@ private CassandraCluster(CassandraModule module, Host host) throws RuntimeExcept
.keyspace(KEYSPACE)
.replicationFactor(1)
.disableDurableWrites();
- this.nonPrivilegedCluster = ClusterFactory.create(clusterConfiguration, keyspaceConfiguration);
+
+ DriverConfigLoader driverConfigLoader = DriverConfigLoader.programmaticBuilder()
+ .withString(DefaultDriverOption.SESSION_LEAK_THRESHOLD, "16")
Review Comment:
CI still fails, It looks not resolve the unstable -> Reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #1689: Fix jvm-*.options when upgrade Docker Cassandra 3 -> 4...
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #1689:
URL: https://github.com/apache/james-project/pull/1689#issuecomment-1687766913
Sure it's alright :) I remember back then we put a limit on those containers so people could run tests locally without bloating their RAM, but for the CI probably better to use more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on a diff in pull request #1689: Fix jvm-*.options when upgrade Docker Cassandra 3 -> 4...
Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on code in PR #1689:
URL: https://github.com/apache/james-project/pull/1689#discussion_r1302763442
##########
backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/DockerCassandra.java:
##########
@@ -169,14 +169,21 @@ public void onComplete() {
public void close() {
}
});
+
+ String memorySettingCommand = Optional.ofNullable(System.getenv("CI"))
Review Comment:
Your mean is `CI` ?
It is already in Jenkinsfile https://github.com/apache/james-project/pull/1689#issuecomment-1687793011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on pull request #1689: Fix jvm-*.options when upgrade Docker Cassandra 3 -> 4...
Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on PR #1689:
URL: https://github.com/apache/james-project/pull/1689#issuecomment-1687729188
Ci green,
When we don't provide configured the Xms, Xmx,
the `cassandra-env.sh` algrothim
```
# set max heap size based on the following
# max(min(1/2 ram, 1024MB), min(1/4 ram, 8GB))
```
=> CI server has 48GB => Cassandra container will run with 8GB
_______
Let's try with 2GB
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #1689: Fix jvm-*.options when upgrade Docker Cassandra 3 -> 4...
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #1689:
URL: https://github.com/apache/james-project/pull/1689#issuecomment-1684094828
`org.apache.james.backends.cassandra.init.SessionWithInitializedTablesFactoryTest.createSessionShouldKeepTheSetSchemaVersionWhenTypesAndTablesHaveNotChanged`
`Query timed out after PT2S`
Maybe give it a bit more memory no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #1689: Fix jvm-*.options when upgrade Docker Cassandra 3 -> 4...
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa merged PR #1689:
URL: https://github.com/apache/james-project/pull/1689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on pull request #1689: Fix jvm-*.options when upgrade Docker Cassandra 3 -> 4...
Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on PR #1689:
URL: https://github.com/apache/james-project/pull/1689#issuecomment-1687312311
CI still fail
```
com.datastax.oss.driver.api.core.DriverTimeoutException: Query timed out after PT2S
getAllMappingsShouldReturnMultipleStoredMappings – org.apache.james.rrt.cassandra.CassandraRecipientRewriteTableDAOTest
readBytesShouldReturnBigSavedByteSource(StoragePolicy)[3] – org.apache.james.blob.cassandra.CassandraBlobStoreClOneTest
```
I will commit no limit memory, and see what happens, (In the past when miss jvm.**options, the pr was green)
That will help trace the reason comes from in-memory exceed or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on a diff in pull request #1689: Fix jvm-*.options when upgrade Docker Cassandra 3 -> 4...
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on code in PR #1689:
URL: https://github.com/apache/james-project/pull/1689#discussion_r1302785038
##########
backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/DockerCassandra.java:
##########
@@ -169,14 +169,21 @@ public void onComplete() {
public void close() {
}
});
+
+ String memorySettingCommand = Optional.ofNullable(System.getenv("CI"))
Review Comment:
My bad :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on pull request #1689: Fix jvm-*.options when upgrade Docker Cassandra 3 -> 4...
Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on PR #1689:
URL: https://github.com/apache/james-project/pull/1689#issuecomment-1690888833
green !!!!, I will squash it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #1689: Fix jvm-*.options when upgrade Docker Cassandra 3 -> 4...
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #1689:
URL: https://github.com/apache/james-project/pull/1689#issuecomment-1691222101
:green_apple: again... Merging!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org