[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4343: Fix MutableArrayData::extend_nulls (#1230)

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #4343:
URL: https://github.com/apache/arrow-rs/pull/4343#discussion_r1214045538


##########
arrow-data/src/transform/mod.rs:
##########
@@ -53,7 +53,7 @@ struct _MutableArrayData<'a> {
     pub null_count: usize,
 
     pub len: usize,
-    pub null_buffer: MutableBuffer,
+    pub null_buffer: Option<MutableBuffer>,

Review Comment:
   This does add a branch on append, in practice appending to a null mask is so branch heavy anyway, not to mention already involving a dyn dispatch, I struggle to see how this could have an appreciable performance impact



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org