You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Navis Ryu <na...@nexr.com> on 2014/03/19 02:36:54 UTC
Review Request 19387: Session state for hive server should be cleaned-up
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19387/
-----------------------------------------------------------
Review request for hive and Ashutosh Chauhan.
Bugs: HIVE-3969
https://issues.apache.org/jira/browse/HIVE-3969
Repository: hive-git
Description
-------
Currently "add jar" command by clients are adding child ClassLoader to worker thread cumulatively, causing various problems.
Diffs
-----
common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 0dba331
ql/src/java/org/apache/hadoop/hive/ql/exec/PTFOperator.java a249d74
ql/src/java/org/apache/hadoop/hive/ql/optimizer/lineage/LineageCtx.java 8d6ebaa
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 5546d03
ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/TableFunctionEvaluator.java 32e78ac
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPNumeric.java 2ada2ff
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java ace791a
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java ef5b5c6
Diff: https://reviews.apache.org/r/19387/diff/
Testing
-------
Thanks,
Navis Ryu
Re: Review Request 19387: Session state for hive server should be cleaned-up
Posted by Navis Ryu <na...@nexr.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19387/
-----------------------------------------------------------
(Updated March 20, 2014, 1:04 a.m.)
Review request for hive and Ashutosh Chauhan.
Changes
-------
Close loader before deleting temporary directory
Merged test case in HIVE-6364
Bugs: HIVE-3969
https://issues.apache.org/jira/browse/HIVE-3969
Repository: hive-git
Description
-------
Currently "add jar" command by clients are adding child ClassLoader to worker thread cumulatively, causing various problems.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 0dba331
ql/src/java/org/apache/hadoop/hive/ql/exec/PTFOperator.java a249d74
ql/src/java/org/apache/hadoop/hive/ql/optimizer/lineage/LineageCtx.java 8d6ebaa
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 5546d03
ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/TableFunctionEvaluator.java 32e78ac
ql/src/test/org/apache/hadoop/hive/ql/session/TestSessionState.java c51ff09
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPNumeric.java 2ada2ff
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java ace791a
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java ef5b5c6
Diff: https://reviews.apache.org/r/19387/diff/
Testing
-------
Thanks,
Navis Ryu
Re: Review Request 19387: Session state for hive server should be cleaned-up
Posted by Navis Ryu <na...@nexr.com>.
> On March 19, 2014, 9:11 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java, line 243
> > <https://reviews.apache.org/r/19387/diff/1/?file=526877#file526877line243>
> >
> > Shouldn't this be parentLoader = conf.getClassLoader()?
When adding resources, parent loader is context loader of current thread(see SessionState#registerJar()). Making it consistent looked good but also, I didn't wanted parent loader to be null. So it's like that. Using conf.getClassLoader() makes me a little unsafe.
- Navis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19387/#review37796
-----------------------------------------------------------
On March 19, 2014, 1:36 a.m., Navis Ryu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19387/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 1:36 a.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-3969
> https://issues.apache.org/jira/browse/HIVE-3969
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Currently "add jar" command by clients are adding child ClassLoader to worker thread cumulatively, causing various problems.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 0dba331
> ql/src/java/org/apache/hadoop/hive/ql/exec/PTFOperator.java a249d74
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/lineage/LineageCtx.java 8d6ebaa
> ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 5546d03
> ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/TableFunctionEvaluator.java 32e78ac
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPNumeric.java 2ada2ff
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java ace791a
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java ef5b5c6
>
> Diff: https://reviews.apache.org/r/19387/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Navis Ryu
>
>
Re: Review Request 19387: Session state for hive server should be cleaned-up
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19387/#review37796
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java
<https://reviews.apache.org/r/19387/#comment69524>
Shouldn't this be parentLoader = conf.getClassLoader()?
- Ashutosh Chauhan
On March 19, 2014, 1:36 a.m., Navis Ryu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19387/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 1:36 a.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-3969
> https://issues.apache.org/jira/browse/HIVE-3969
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Currently "add jar" command by clients are adding child ClassLoader to worker thread cumulatively, causing various problems.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 0dba331
> ql/src/java/org/apache/hadoop/hive/ql/exec/PTFOperator.java a249d74
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/lineage/LineageCtx.java 8d6ebaa
> ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 5546d03
> ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/TableFunctionEvaluator.java 32e78ac
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPNumeric.java 2ada2ff
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java ace791a
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java ef5b5c6
>
> Diff: https://reviews.apache.org/r/19387/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Navis Ryu
>
>