You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Timothy Bish (JIRA)" <ji...@apache.org> on 2010/07/08 23:00:51 UTC

[jira] Created: (AMQNET-259) Multiple RequestTimeout Options in NMS.ActiveMQ causes option to not work when used with Failover.

Multiple RequestTimeout Options in NMS.ActiveMQ causes option to not work when used with Failover.
--------------------------------------------------------------------------------------------------

                 Key: AMQNET-259
                 URL: https://issues.apache.org/activemq/browse/AMQNET-259
             Project: ActiveMQ .Net
          Issue Type: Bug
          Components: ActiveMQ
    Affects Versions: 1.3.0, 1.2.0
            Reporter: Timothy Bish
            Assignee: Jim Gomes
            Priority: Minor
             Fix For: 1.4.0


NMS.ActiveMQ has several different places where a RequestTimeout option is able to be configured.  The one in the Transport layer severs no real purpose any more and can lead to confusion as its not able to be set correctly when the FailoverTransport is used as the layering of Transports hides the value.   The Connection object has its own RequestTimeout and should be the only one we need as it is used to set the value for the Session and Producer classes.  

I'd like to remove the RequestTimeout option from the Transports layer altogether since the timeout is actually specified in the request call that takes a timeout option.  

Also the current ConnectionFactory doesn't properly configure the Connection.RequestTimeout if set on the URI, this should be fixed here as well. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (AMQNET-259) Multiple RequestTimeout Options in NMS.ActiveMQ causes option to not work when used with Failover.

Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQNET-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish reassigned AMQNET-259:
-----------------------------------

    Assignee: Timothy Bish  (was: Jim Gomes)

> Multiple RequestTimeout Options in NMS.ActiveMQ causes option to not work when used with Failover.
> --------------------------------------------------------------------------------------------------
>
>                 Key: AMQNET-259
>                 URL: https://issues.apache.org/activemq/browse/AMQNET-259
>             Project: ActiveMQ .Net
>          Issue Type: Bug
>          Components: ActiveMQ
>    Affects Versions: 1.2.0, 1.3.0
>            Reporter: Timothy Bish
>            Assignee: Timothy Bish
>            Priority: Minor
>             Fix For: 1.4.0
>
>
> NMS.ActiveMQ has several different places where a RequestTimeout option is able to be configured.  The one in the Transport layer severs no real purpose any more and can lead to confusion as its not able to be set correctly when the FailoverTransport is used as the layering of Transports hides the value.   The Connection object has its own RequestTimeout and should be the only one we need as it is used to set the value for the Session and Producer classes.  
> I'd like to remove the RequestTimeout option from the Transports layer altogether since the timeout is actually specified in the request call that takes a timeout option.  
> Also the current ConnectionFactory doesn't properly configure the Connection.RequestTimeout if set on the URI, this should be fixed here as well. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AMQNET-259) Multiple RequestTimeout Options in NMS.ActiveMQ causes option to not work when used with Failover.

Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQNET-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=60523#action_60523 ] 

Timothy Bish commented on AMQNET-259:
-------------------------------------

This probably affects NMS.Stomp as well as a lot of the code is copied from NMS.ActiveMQ

> Multiple RequestTimeout Options in NMS.ActiveMQ causes option to not work when used with Failover.
> --------------------------------------------------------------------------------------------------
>
>                 Key: AMQNET-259
>                 URL: https://issues.apache.org/activemq/browse/AMQNET-259
>             Project: ActiveMQ .Net
>          Issue Type: Bug
>          Components: ActiveMQ
>    Affects Versions: 1.2.0, 1.3.0
>            Reporter: Timothy Bish
>            Assignee: Timothy Bish
>            Priority: Minor
>             Fix For: 1.4.0
>
>
> NMS.ActiveMQ has several different places where a RequestTimeout option is able to be configured.  The one in the Transport layer severs no real purpose any more and can lead to confusion as its not able to be set correctly when the FailoverTransport is used as the layering of Transports hides the value.   The Connection object has its own RequestTimeout and should be the only one we need as it is used to set the value for the Session and Producer classes.  
> I'd like to remove the RequestTimeout option from the Transports layer altogether since the timeout is actually specified in the request call that takes a timeout option.  
> Also the current ConnectionFactory doesn't properly configure the Connection.RequestTimeout if set on the URI, this should be fixed here as well. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AMQNET-259) Multiple RequestTimeout Options in NMS.ActiveMQ causes option to not work when used with Failover.

Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQNET-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish updated AMQNET-259:
--------------------------------

    Component/s: Stomp

> Multiple RequestTimeout Options in NMS.ActiveMQ causes option to not work when used with Failover.
> --------------------------------------------------------------------------------------------------
>
>                 Key: AMQNET-259
>                 URL: https://issues.apache.org/activemq/browse/AMQNET-259
>             Project: ActiveMQ .Net
>          Issue Type: Bug
>          Components: ActiveMQ, Stomp
>    Affects Versions: 1.2.0, 1.3.0
>            Reporter: Timothy Bish
>            Assignee: Timothy Bish
>            Priority: Minor
>             Fix For: 1.4.0
>
>
> NMS.ActiveMQ has several different places where a RequestTimeout option is able to be configured.  The one in the Transport layer severs no real purpose any more and can lead to confusion as its not able to be set correctly when the FailoverTransport is used as the layering of Transports hides the value.   The Connection object has its own RequestTimeout and should be the only one we need as it is used to set the value for the Session and Producer classes.  
> I'd like to remove the RequestTimeout option from the Transports layer altogether since the timeout is actually specified in the request call that takes a timeout option.  
> Also the current ConnectionFactory doesn't properly configure the Connection.RequestTimeout if set on the URI, this should be fixed here as well. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (AMQNET-259) Multiple RequestTimeout Options in NMS.ActiveMQ causes option to not work when used with Failover.

Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQNET-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish resolved AMQNET-259.
---------------------------------

    Resolution: Fixed

Updated the code so that there is only one RequestTimeout that's set in the Connection object and can be set via ConnectionFactory.  Cleaned up the FutureResponse class and improved error handling and shutdown code in ResponseCorrelator.



> Multiple RequestTimeout Options in NMS.ActiveMQ causes option to not work when used with Failover.
> --------------------------------------------------------------------------------------------------
>
>                 Key: AMQNET-259
>                 URL: https://issues.apache.org/activemq/browse/AMQNET-259
>             Project: ActiveMQ .Net
>          Issue Type: Bug
>          Components: ActiveMQ, Stomp
>    Affects Versions: 1.2.0, 1.3.0
>            Reporter: Timothy Bish
>            Assignee: Timothy Bish
>            Priority: Minor
>             Fix For: 1.4.0
>
>
> NMS.ActiveMQ has several different places where a RequestTimeout option is able to be configured.  The one in the Transport layer severs no real purpose any more and can lead to confusion as its not able to be set correctly when the FailoverTransport is used as the layering of Transports hides the value.   The Connection object has its own RequestTimeout and should be the only one we need as it is used to set the value for the Session and Producer classes.  
> I'd like to remove the RequestTimeout option from the Transports layer altogether since the timeout is actually specified in the request call that takes a timeout option.  
> Also the current ConnectionFactory doesn't properly configure the Connection.RequestTimeout if set on the URI, this should be fixed here as well. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.