You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/06 05:42:40 UTC

[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #271: [request for feedback] [breaking change] fix 265, log should be log10, and add ln

Jimexist commented on a change in pull request #271:
URL: https://github.com/apache/arrow-datafusion/pull/271#discussion_r627092828



##########
File path: datafusion/src/logical_plan/expr.rs
##########
@@ -1086,9 +1086,9 @@ unary_scalar_expr!(Trunc, trunc);
 unary_scalar_expr!(Abs, abs);
 unary_scalar_expr!(Signum, signum);
 unary_scalar_expr!(Exp, exp);
-unary_scalar_expr!(Log, ln);

Review comment:
       i guess it's kept at the https://github.com/apache/arrow-datafusion/pull/271/files#diff-97178da6c90bfcb5e3dc80f06248ac1aebdec5a0e0e1d8ea235e2f571b5badf8R227 level, not here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org