You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Chris Riccomini <cr...@apache.org> on 2014/07/30 09:37:34 UTC
Review Request 24092: SAMZA-359
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24092/
-----------------------------------------------------------
Review request for samza.
Bugs: SAMZA-359
https://issues.apache.org/jira/browse/SAMZA-359
Repository: samza
Description
-------
all tests compile
build passes
partial refactor of package space post SAMZA-123
Diffs
-----
samza-api/src/main/java/org/apache/samza/container/SystemStreamPartitionGrouper.java 897d9f505bb6e87cc4afdea3443fe9c63fae7828
samza-api/src/main/java/org/apache/samza/container/SystemStreamPartitionGrouperFactory.java 10ac6e202c539e4ef5cde7523ded387fd1525ed5
samza-api/src/main/java/org/apache/samza/container/TaskName.java 13a1206abf9bf719f9f91cb9d5934732d83c05d7
samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala f84aeea64050df79b429f3020c22155dafe4230a
samza-core/src/main/scala/org/apache/samza/container/SystemStreamPartitionTaskNameGrouper.scala a8c93acd8c5fe7c994c6aff2129e2bc4657a2eeb
samza-core/src/main/scala/org/apache/samza/container/systemstreampartition/groupers/GroupByPartition.scala 223862f10338267d6fda00aab4de81fe2d079bdf
samza-core/src/main/scala/org/apache/samza/container/systemstreampartition/groupers/GroupBySystemStreamPartition.scala a2bcfeef7ff0a238788844e9864bd89f7ffc7adb
samza-core/src/main/scala/org/apache/samza/container/systemstreampartition/taskname/groupers/SimpleSystemStreamPartitionTaskNameGrouper.scala 7913294b517a7414e35f1e7909821b72bea4183a
samza-core/src/main/scala/org/apache/samza/util/Util.scala 32c2647edca435ad42d5de11608b7f2adb46c7df
samza-core/src/test/scala/org/apache/samza/container/SystemStreamPartitionGrouperTestBase.scala 3032b00ceba5b2778766e02358718adc490ecd72
samza-core/src/test/scala/org/apache/samza/container/systemstreampartition/groupers/TestGroupByPartition.scala 733be208e0081b8b22629cec271a368cc039798c
samza-core/src/test/scala/org/apache/samza/container/systemstreampartition/groupers/TestGroupBySystemStreamPartition.scala e9c15a5ef62722aaf496d179912d89553b80b22b
samza-core/src/test/scala/org/apache/samza/container/systemstreampartition/taskname/groupers/TestSimpleSystemStreamPartitionTaskNameGrouper.scala 7ea09cd74156f9ea2fe140fa9786fc5d7db874b8
samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala cddee13d99e6598af5b41024caff7d79c1ad516d
Diff: https://reviews.apache.org/r/24092/diff/
Testing
-------
Thanks,
Chris Riccomini
Re: Review Request 24092: SAMZA-359
Posted by Naveen Somasundaram <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24092/#review49129
-----------------------------------------------------------
Ship it!
Ship It!
- Naveen Somasundaram
On July 30, 2014, 7:37 a.m., Chris Riccomini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24092/
> -----------------------------------------------------------
>
> (Updated July 30, 2014, 7:37 a.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-359
> https://issues.apache.org/jira/browse/SAMZA-359
>
>
> Repository: samza
>
>
> Description
> -------
>
> all tests compile
>
>
> build passes
>
>
> partial refactor of package space post SAMZA-123
>
>
> Diffs
> -----
>
> samza-api/src/main/java/org/apache/samza/container/SystemStreamPartitionGrouper.java 897d9f505bb6e87cc4afdea3443fe9c63fae7828
> samza-api/src/main/java/org/apache/samza/container/SystemStreamPartitionGrouperFactory.java 10ac6e202c539e4ef5cde7523ded387fd1525ed5
> samza-api/src/main/java/org/apache/samza/container/TaskName.java 13a1206abf9bf719f9f91cb9d5934732d83c05d7
> samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala f84aeea64050df79b429f3020c22155dafe4230a
> samza-core/src/main/scala/org/apache/samza/container/SystemStreamPartitionTaskNameGrouper.scala a8c93acd8c5fe7c994c6aff2129e2bc4657a2eeb
> samza-core/src/main/scala/org/apache/samza/container/systemstreampartition/groupers/GroupByPartition.scala 223862f10338267d6fda00aab4de81fe2d079bdf
> samza-core/src/main/scala/org/apache/samza/container/systemstreampartition/groupers/GroupBySystemStreamPartition.scala a2bcfeef7ff0a238788844e9864bd89f7ffc7adb
> samza-core/src/main/scala/org/apache/samza/container/systemstreampartition/taskname/groupers/SimpleSystemStreamPartitionTaskNameGrouper.scala 7913294b517a7414e35f1e7909821b72bea4183a
> samza-core/src/main/scala/org/apache/samza/util/Util.scala 32c2647edca435ad42d5de11608b7f2adb46c7df
> samza-core/src/test/scala/org/apache/samza/container/SystemStreamPartitionGrouperTestBase.scala 3032b00ceba5b2778766e02358718adc490ecd72
> samza-core/src/test/scala/org/apache/samza/container/systemstreampartition/groupers/TestGroupByPartition.scala 733be208e0081b8b22629cec271a368cc039798c
> samza-core/src/test/scala/org/apache/samza/container/systemstreampartition/groupers/TestGroupBySystemStreamPartition.scala e9c15a5ef62722aaf496d179912d89553b80b22b
> samza-core/src/test/scala/org/apache/samza/container/systemstreampartition/taskname/groupers/TestSimpleSystemStreamPartitionTaskNameGrouper.scala 7ea09cd74156f9ea2fe140fa9786fc5d7db874b8
> samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala cddee13d99e6598af5b41024caff7d79c1ad516d
>
> Diff: https://reviews.apache.org/r/24092/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Riccomini
>
>
Re: Review Request 24092: SAMZA-359
Posted by Yan Fang <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24092/#review49144
-----------------------------------------------------------
Ship it!
Ship It!
- Yan Fang
On July 30, 2014, 6:31 p.m., Chris Riccomini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24092/
> -----------------------------------------------------------
>
> (Updated July 30, 2014, 6:31 p.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-359
> https://issues.apache.org/jira/browse/SAMZA-359
>
>
> Repository: samza
>
>
> Description
> -------
>
> fixing missed package space
>
>
> all tests compile
>
>
> build passes
>
>
> partial refactor of package space post SAMZA-123
>
>
> Diffs
> -----
>
> samza-api/src/main/java/org/apache/samza/container/SystemStreamPartitionGrouper.java 897d9f505bb6e87cc4afdea3443fe9c63fae7828
> samza-api/src/main/java/org/apache/samza/container/SystemStreamPartitionGrouperFactory.java 10ac6e202c539e4ef5cde7523ded387fd1525ed5
> samza-api/src/main/java/org/apache/samza/container/TaskName.java 13a1206abf9bf719f9f91cb9d5934732d83c05d7
> samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala f84aeea64050df79b429f3020c22155dafe4230a
> samza-core/src/main/scala/org/apache/samza/container/SystemStreamPartitionTaskNameGrouper.scala a8c93acd8c5fe7c994c6aff2129e2bc4657a2eeb
> samza-core/src/main/scala/org/apache/samza/container/systemstreampartition/groupers/GroupByPartition.scala 223862f10338267d6fda00aab4de81fe2d079bdf
> samza-core/src/main/scala/org/apache/samza/container/systemstreampartition/groupers/GroupBySystemStreamPartition.scala a2bcfeef7ff0a238788844e9864bd89f7ffc7adb
> samza-core/src/main/scala/org/apache/samza/container/systemstreampartition/taskname/groupers/SimpleSystemStreamPartitionTaskNameGrouper.scala 7913294b517a7414e35f1e7909821b72bea4183a
> samza-core/src/main/scala/org/apache/samza/util/Util.scala 32c2647edca435ad42d5de11608b7f2adb46c7df
> samza-core/src/test/scala/org/apache/samza/container/SystemStreamPartitionGrouperTestBase.scala 3032b00ceba5b2778766e02358718adc490ecd72
> samza-core/src/test/scala/org/apache/samza/container/systemstreampartition/groupers/TestGroupByPartition.scala 733be208e0081b8b22629cec271a368cc039798c
> samza-core/src/test/scala/org/apache/samza/container/systemstreampartition/groupers/TestGroupBySystemStreamPartition.scala e9c15a5ef62722aaf496d179912d89553b80b22b
> samza-core/src/test/scala/org/apache/samza/container/systemstreampartition/taskname/groupers/TestSimpleSystemStreamPartitionTaskNameGrouper.scala 7ea09cd74156f9ea2fe140fa9786fc5d7db874b8
> samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala cddee13d99e6598af5b41024caff7d79c1ad516d
>
> Diff: https://reviews.apache.org/r/24092/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Riccomini
>
>
Re: Review Request 24092: SAMZA-359
Posted by Chris Riccomini <cr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24092/
-----------------------------------------------------------
(Updated July 30, 2014, 6:31 p.m.)
Review request for samza.
Bugs: SAMZA-359
https://issues.apache.org/jira/browse/SAMZA-359
Repository: samza
Description (updated)
-------
fixing missed package space
all tests compile
build passes
partial refactor of package space post SAMZA-123
Diffs (updated)
-----
samza-api/src/main/java/org/apache/samza/container/SystemStreamPartitionGrouper.java 897d9f505bb6e87cc4afdea3443fe9c63fae7828
samza-api/src/main/java/org/apache/samza/container/SystemStreamPartitionGrouperFactory.java 10ac6e202c539e4ef5cde7523ded387fd1525ed5
samza-api/src/main/java/org/apache/samza/container/TaskName.java 13a1206abf9bf719f9f91cb9d5934732d83c05d7
samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala f84aeea64050df79b429f3020c22155dafe4230a
samza-core/src/main/scala/org/apache/samza/container/SystemStreamPartitionTaskNameGrouper.scala a8c93acd8c5fe7c994c6aff2129e2bc4657a2eeb
samza-core/src/main/scala/org/apache/samza/container/systemstreampartition/groupers/GroupByPartition.scala 223862f10338267d6fda00aab4de81fe2d079bdf
samza-core/src/main/scala/org/apache/samza/container/systemstreampartition/groupers/GroupBySystemStreamPartition.scala a2bcfeef7ff0a238788844e9864bd89f7ffc7adb
samza-core/src/main/scala/org/apache/samza/container/systemstreampartition/taskname/groupers/SimpleSystemStreamPartitionTaskNameGrouper.scala 7913294b517a7414e35f1e7909821b72bea4183a
samza-core/src/main/scala/org/apache/samza/util/Util.scala 32c2647edca435ad42d5de11608b7f2adb46c7df
samza-core/src/test/scala/org/apache/samza/container/SystemStreamPartitionGrouperTestBase.scala 3032b00ceba5b2778766e02358718adc490ecd72
samza-core/src/test/scala/org/apache/samza/container/systemstreampartition/groupers/TestGroupByPartition.scala 733be208e0081b8b22629cec271a368cc039798c
samza-core/src/test/scala/org/apache/samza/container/systemstreampartition/groupers/TestGroupBySystemStreamPartition.scala e9c15a5ef62722aaf496d179912d89553b80b22b
samza-core/src/test/scala/org/apache/samza/container/systemstreampartition/taskname/groupers/TestSimpleSystemStreamPartitionTaskNameGrouper.scala 7ea09cd74156f9ea2fe140fa9786fc5d7db874b8
samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala cddee13d99e6598af5b41024caff7d79c1ad516d
Diff: https://reviews.apache.org/r/24092/diff/
Testing
-------
Thanks,
Chris Riccomini
Re: Review Request 24092: SAMZA-359
Posted by Yan Fang <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24092/#review49106
-----------------------------------------------------------
All look good for me. Just miss one change. Thank you.
samza-core/src/main/scala/org/apache/samza/container/SystemStreamPartitionTaskNameGrouper.scala
<https://reviews.apache.org/r/24092/#comment85943>
missed this one.
- Yan Fang
On July 30, 2014, 7:37 a.m., Chris Riccomini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24092/
> -----------------------------------------------------------
>
> (Updated July 30, 2014, 7:37 a.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-359
> https://issues.apache.org/jira/browse/SAMZA-359
>
>
> Repository: samza
>
>
> Description
> -------
>
> all tests compile
>
>
> build passes
>
>
> partial refactor of package space post SAMZA-123
>
>
> Diffs
> -----
>
> samza-api/src/main/java/org/apache/samza/container/SystemStreamPartitionGrouper.java 897d9f505bb6e87cc4afdea3443fe9c63fae7828
> samza-api/src/main/java/org/apache/samza/container/SystemStreamPartitionGrouperFactory.java 10ac6e202c539e4ef5cde7523ded387fd1525ed5
> samza-api/src/main/java/org/apache/samza/container/TaskName.java 13a1206abf9bf719f9f91cb9d5934732d83c05d7
> samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala f84aeea64050df79b429f3020c22155dafe4230a
> samza-core/src/main/scala/org/apache/samza/container/SystemStreamPartitionTaskNameGrouper.scala a8c93acd8c5fe7c994c6aff2129e2bc4657a2eeb
> samza-core/src/main/scala/org/apache/samza/container/systemstreampartition/groupers/GroupByPartition.scala 223862f10338267d6fda00aab4de81fe2d079bdf
> samza-core/src/main/scala/org/apache/samza/container/systemstreampartition/groupers/GroupBySystemStreamPartition.scala a2bcfeef7ff0a238788844e9864bd89f7ffc7adb
> samza-core/src/main/scala/org/apache/samza/container/systemstreampartition/taskname/groupers/SimpleSystemStreamPartitionTaskNameGrouper.scala 7913294b517a7414e35f1e7909821b72bea4183a
> samza-core/src/main/scala/org/apache/samza/util/Util.scala 32c2647edca435ad42d5de11608b7f2adb46c7df
> samza-core/src/test/scala/org/apache/samza/container/SystemStreamPartitionGrouperTestBase.scala 3032b00ceba5b2778766e02358718adc490ecd72
> samza-core/src/test/scala/org/apache/samza/container/systemstreampartition/groupers/TestGroupByPartition.scala 733be208e0081b8b22629cec271a368cc039798c
> samza-core/src/test/scala/org/apache/samza/container/systemstreampartition/groupers/TestGroupBySystemStreamPartition.scala e9c15a5ef62722aaf496d179912d89553b80b22b
> samza-core/src/test/scala/org/apache/samza/container/systemstreampartition/taskname/groupers/TestSimpleSystemStreamPartitionTaskNameGrouper.scala 7ea09cd74156f9ea2fe140fa9786fc5d7db874b8
> samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala cddee13d99e6598af5b41024caff7d79c1ad516d
>
> Diff: https://reviews.apache.org/r/24092/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Riccomini
>
>