[GitHub] [incubator-paimon] chestnutqiang commented on a diff in pull request #1762: [core] The config of changelog format and file format are separated

["chestnutqiang (via GitHub)" <gi...@apache.org>]

chestnutqiang commented on code in PR #1762:
URL: https://github.com/apache/incubator-paimon/pull/1762#discussion_r1287862117


##########
paimon-common/src/main/java/org/apache/paimon/CoreOptions.java:
##########
@@ -139,6 +138,40 @@ public class CoreOptions implements Serializable {
                             "Default file compression format, can be overridden by "
                                     + FILE_COMPRESSION_PER_LEVEL.key());
 
+    public static final ConfigOption<FileFormatType> CHANGELOG_FORMAT =
+            key("changelog.format")
+                    .enumType(FileFormatType.class)
+                    .defaultValue(FileFormatType.ORC)
+                    .withDescription(
+                            "Specify the message format of changelog files, currently orc, parquet and avro are supported.");
+
+    public static final ConfigOption<String> CHANGELOG_COMPRESSION =
+            key("changelog.compression")
+                    .stringType()
+                    .noDefaultValue()
+                    .withDescription("Default changelog compression format.");
+
+    public static final ConfigOption<Map<String, String>> CHANGELOG_COMPRESSION_PER_LEVEL =

Review Comment:
   It depends on whether any compaction happens on the changelog and how small a file there is if you don't compate. I mean, changelog doesn't need to sort even when it does small file merges because it's in chronological order.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org