You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lucenenet.apache.org by laimis <gi...@git.apache.org> on 2015/04/22 02:49:13 UTC

[GitHub] lucenenet pull request: change how TopTermsRewrite instance of is ...

GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/130

    change how TopTermsRewrite instance of is checked

    Changing the logic that checks if rewrite method is an instance of some sort of TopTermsRewrite to match Lucene. Key change is here:
    
    https://github.com/apache/lucenenet/compare/master...laimis:fuzzyquery_fix?expand=1#diff-605c6558db33049a7e4d93482e5432aeL67
    
    Instead of checking for TopTermsRewrite<Q>, it seems like Lucene cares only if it is TopTermsRewrite based class but does not care what parameter type is used and it does not need to match SpanMultiTermQueryWrapper parameter type:
    
    https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/core/src/java/org/apache/lucene/search/spans/SpanMultiTermQueryWrapper.java#L68
    
    At least that's how interpreted it. The tests seem to pass and this also fixes failing test in TestSpanMultiTermQueryWrapper. TestFuzzy2

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet fuzzyquery_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/130.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #130
    
----
commit d021a5228de4a35e82c96ad45266ec5a520d7e0f
Author: Laimonas Simutis <la...@gmail.com>
Date:   2015-04-22T00:43:04Z

    change how TopTermsRewrite instance of is checked

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] lucenenet pull request: change how TopTermsRewrite instance of is ...

Posted by laimis <gi...@git.apache.org>.

Github user laimis commented on the pull request:

    https://github.com/apache/lucenenet/pull/130#issuecomment-95382737
  
    Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] lucenenet pull request: change how TopTermsRewrite instance of is ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/lucenenet/pull/130


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] lucenenet pull request: change how TopTermsRewrite instance of is ...

Posted by synhershko <gi...@git.apache.org>.

Github user synhershko commented on the pull request:

    https://github.com/apache/lucenenet/pull/130#issuecomment-95234992
  
    Is there a reason to have that marker interface public and not kept private?
    
    While I'd assume there are more places like this, I wonder if we can assume they are all internal and avoid exposing this interface?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] lucenenet pull request: change how TopTermsRewrite instance of is ...

Posted by laimis <gi...@git.apache.org>.

Github user laimis commented on the pull request:

    https://github.com/apache/lucenenet/pull/130#issuecomment-95374953
  
    @synhershko great point, I will adjust, there is no need for it to be public.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---