You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/07/02 11:52:13 UTC

[GitHub] wtrocki commented on issue #32: Simplify the IOS orientation logic

wtrocki commented on issue #32: Simplify the IOS orientation logic
URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/32#issuecomment-401779483
 
 
   @jcesarmobile There are many quirks on IOS for this method.
   A call to attemptRotationToDeviceOrientation only rotates the orientation of the interface, if and only if, the device itself has been rotated. Previous code tried to workaround that by remembering last position which was source of couple issues.
   
   Also operating system preferences are used (application can override them as in this plugin, but if we unlock then operating system options are taken into account. 
   
   I think that this PR https://github.com/apache/cordova-plugin-screen-orientation/pull/31 has similar fix (I haven't noticed that before). 
   We just need to rebase that PR with the recent master changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org