You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by da...@apache.org on 2011/07/09 02:55:41 UTC
svn commit: r1144562 -
/subversion/branches/revprop-packing/subversion/libsvn_fs_fs/fs_fs.c
Author: danielsh
Date: Sat Jul 9 00:55:41 2011
New Revision: 1144562
URL: http://svn.apache.org/viewvc?rev=1144562&view=rev
Log:
On the revprop-packing branch:
Fix a memory overread bug parsing the manifest.
* subversion/libsvn_fs_fs/fs_fs.c
(revision_proplist): Terminate BUF by NUL.
Modified:
subversion/branches/revprop-packing/subversion/libsvn_fs_fs/fs_fs.c
Modified: subversion/branches/revprop-packing/subversion/libsvn_fs_fs/fs_fs.c
URL: http://svn.apache.org/viewvc/subversion/branches/revprop-packing/subversion/libsvn_fs_fs/fs_fs.c?rev=1144562&r1=1144561&r2=1144562&view=diff
==============================================================================
--- subversion/branches/revprop-packing/subversion/libsvn_fs_fs/fs_fs.c (original)
+++ subversion/branches/revprop-packing/subversion/libsvn_fs_fs/fs_fs.c Sat Jul 9 00:55:41 2011
@@ -3264,6 +3264,7 @@ revision_proplist(apr_hash_t **proplist_
/* Read the revprop offset. */
SVN_ERR(svn_stream_read(svn_stream_from_aprfile2(pack_file, TRUE, pool),
buf, &len));
+ buf[len] = '\0';
/* Seek to the revprop offset, and read the props. */
offset = REVPROP_MANIFEST_FIELD_WIDTH * ffd->max_files_per_dir