You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/13 07:24:45 UTC
[GitHub] [spark] cloud-fan opened a new pull request #28199:
[SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
cloud-fan opened a new pull request #28199: [SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Refine the code comments of days rebasing, to be consistent with the micros rebasing. i.e. one method is the actual implementation and a variant of the optimized version.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
improve code comments
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
N/A
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28199: [SPARK-31402][FOLLOWUP]
Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28199: [SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-612786933
**[Test build #121183 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121183/testReport)** for PR 28199 at commit [`bd34313`](https://github.com/apache/spark/commit/bd34313b4b45a5a0998cc6075a4b2596086d2560).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #28199:
[SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #28199: [SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28199:
[SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28199: [SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-613263980
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121254/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28199:
[SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28199: [SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-612787307
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25870/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28199:
[SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28199: [SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-612787298
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28199:
[SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28199: [SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-612882625
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28199:
[SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28199: [SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-612984645
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121208/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #28199:
[SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #28199: [SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-612786973
cc @MaxGekk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28199:
[SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28199: [SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-613231147
**[Test build #121254 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121254/testReport)** for PR 28199 at commit [`bd34313`](https://github.com/apache/spark/commit/bd34313b4b45a5a0998cc6075a4b2596086d2560).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28199: [SPARK-31402][FOLLOWUP]
Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28199: [SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-612984252
**[Test build #121208 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121208/testReport)** for PR 28199 at commit [`bd34313`](https://github.com/apache/spark/commit/bd34313b4b45a5a0998cc6075a4b2596086d2560).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28199:
[SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28199: [SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-612857306
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121183/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28199:
[SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28199: [SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-613231147
**[Test build #121254 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121254/testReport)** for PR 28199 at commit [`bd34313`](https://github.com/apache/spark/commit/bd34313b4b45a5a0998cc6075a4b2596086d2560).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28199:
[SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28199: [SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-612882632
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25896/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #28199:
[SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #28199: [SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-613229841
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #28199:
[SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #28199: [SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-613290634
yea it's comment only, we don't need to wait for tests. merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28199:
[SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28199: [SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-612984633
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28199:
[SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28199: [SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-613231468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25941/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28199: [SPARK-31402][FOLLOWUP]
Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28199: [SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-612882287
**[Test build #121208 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121208/testReport)** for PR 28199 at commit [`bd34313`](https://github.com/apache/spark/commit/bd34313b4b45a5a0998cc6075a4b2596086d2560).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28199:
[SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28199: [SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-612857306
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121183/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28199:
[SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28199: [SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-612857302
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28199:
[SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28199: [SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-613231464
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28199:
[SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28199: [SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-613263980
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121254/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28199:
[SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28199: [SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-612882287
**[Test build #121208 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121208/testReport)** for PR 28199 at commit [`bd34313`](https://github.com/apache/spark/commit/bd34313b4b45a5a0998cc6075a4b2596086d2560).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28199:
[SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28199: [SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-612787307
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25870/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28199: [SPARK-31402][FOLLOWUP]
Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28199: [SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-612856984
**[Test build #121183 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121183/testReport)** for PR 28199 at commit [`bd34313`](https://github.com/apache/spark/commit/bd34313b4b45a5a0998cc6075a4b2596086d2560).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28199:
[SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28199: [SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-613263972
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #28199:
[SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #28199: [SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-612881092
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28199:
[SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28199: [SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-612786933
**[Test build #121183 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121183/testReport)** for PR 28199 at commit [`bd34313`](https://github.com/apache/spark/commit/bd34313b4b45a5a0998cc6075a4b2596086d2560).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28199:
[SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28199: [SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-612882625
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #28199:
[SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #28199: [SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-613241629
@cloud-fan This is just changes in comments. It can be merged if the build succeed? I just want to avoid rebasing of my other PRs that might conflicts with this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28199:
[SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28199: [SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-612882632
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25896/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28199:
[SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28199: [SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-612857302
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28199:
[SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28199: [SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-613263972
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28199:
[SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28199: [SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-613263781
**[Test build #121254 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121254/testReport)** for PR 28199 at commit [`bd34313`](https://github.com/apache/spark/commit/bd34313b4b45a5a0998cc6075a4b2596086d2560).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28199:
[SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28199: [SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-613231468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25941/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28199:
[SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28199: [SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-612984633
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28199:
[SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28199: [SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-613231464
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28199:
[SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28199: [SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-612984645
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121208/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28199:
[SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28199: [SPARK-31402][FOLLOWUP] Refine code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28199#issuecomment-612787298
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org