[jira] [Commented] (WHIRR-297) Separate ZooKeeper and ElasticSearch install and configuration scripts into more generic functions

["Tom White (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WHIRR-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029122#comment-13029122 ] 

Tom White commented on WHIRR-297:
---------------------------------

+1 Looks good, with one caveat. I would rather ScriptBasedClusterAction didn't install any scripts by default, since they may not be needed by all services, and they bulk up the aggregated scripts that are transferred over SSH to each node. Also, in a Puppet or Chef world, they would be unused, I think.

Would it be reasonable to have action handlers do the registration? (I'm thinking that we could shorten the syntax so you can register more than one script in one go: e.g. {{addStatements(event, allOf("install_java", "install_service", "remove_service"));}} - this could go in a future JIRA, if needed.)

> Separate ZooKeeper and ElasticSearch install and configuration scripts into more generic functions
> --------------------------------------------------------------------------------------------------
>
>                 Key: WHIRR-297
>                 URL: https://issues.apache.org/jira/browse/WHIRR-297
>             Project: Whirr
>          Issue Type: Sub-task
>          Components: service/elasticsearch, service/zookeeper
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>             Fix For: 0.5.0
>
>         Attachments: WHIRR-297.patch
>
>
> Separate ZooKeeper and ElasticSearch install and configuration scripts into more generic functions.
> We should have something like: 
> {start,stop,install,configure,cleanup}_zookeeper
> {start,stop,install,configure,cleanup}_elasticsearch
> Naming consistency would be helpful.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira