You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/10 10:41:40 UTC
[GitHub] [incubator-yunikorn-k8shim] pbacsko commented on a change in pull request #381: [YUNIKORN-638] Make placeholder image configurable
pbacsko commented on a change in pull request #381:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/381#discussion_r823583702
##########
File path: deployments/image/configmap/start-yunikorn.sh
##########
@@ -32,4 +32,5 @@ exec /opt/yunikorn/bin/k8s_yunikorn_scheduler \
-operatorPlugins="${OPERATOR_PLUGINS}" \
-enableConfigHotRefresh="${ENABLE_CONFIG_HOT_REFRESH}" \
-disableGangScheduling="${DISABLE_GANG_SCHEDULING}" \
- -userLabelKey="${USER_LABEL_KEY}"
+ -userLabelKey="${USER_LABEL_KEY}" \
+ -placeHolderImage="${PLACEHOLDER_IMAGE}"
Review comment:
Note: I haven't updated the Dockerfile with stuff like `ENV PLACEHOLDER_IMAGE "k8s.gcr.io/pause"` because we already have this value in `constants.go` and `values.yaml`. In fact, lot of settings are already duplicated like log encoding, kube burst, kube QPS, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org