[GitHub] [iceberg] SreeramGarlapati commented on a diff in pull request #4473: Spark 3.2: Commit consumed offsets to the checkpoint location

[GitBox <gi...@apache.org>]

SreeramGarlapati commented on code in PR #4473:
URL: https://github.com/apache/iceberg/pull/4473#discussion_r878615173


##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkMicroBatchStream.java:
##########
@@ -273,14 +275,13 @@ public StreamingOffset initialOffset() {
       table.refresh();
       StreamingOffset offset = determineStartingOffset(table, fromTimestamp);
 
-      OutputFile outputFile = io.newOutputFile(initialOffsetLocation);
-      writeOffset(offset, outputFile);
-
+      writeOffset(offset);
       return offset;
     }
 
-    private void writeOffset(StreamingOffset offset, OutputFile file) {
-      try (OutputStream outputStream = file.create()) {
+    private void writeOffset(StreamingOffset offset) {
+      OutputFile file = io.newOutputFile(initialOffsetLocation);

Review Comment:
   @singhpk234 - multiple spark streaming clusters cannot run based on the same checkpoint location.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org