You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/09 12:37:03 UTC
[I] feat: audit Prometheus data source mutations [rocketmq-dashboard]
Aias00 opened a new issue, #1300:
URL: https://github.com/apache/rocketmq-dashboard/issues/1300
## Problem
Data-source create, update, and delete operations change the control-plane metrics configuration but currently bypass `OperationAuditService`. Operators cannot trace who changed a Prometheus-compatible data source.
## Expected behavior
Record successful data-source create, update, and delete operations in the existing operation-audit table. Audit details must contain only non-sensitive identifiers and metadata; credentials, bearer tokens, and passwords must never be recorded.
## Scope
- Reuse the existing `OperationAuditService` from `SettingsService`.
- Cover create, update, delete success paths with unit tests.
- Keep existing persistence and API contracts unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: audit Prometheus data source mutations [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #1300: feat: audit Prometheus data source mutations
URL: https://github.com/apache/rocketmq-dashboard/issues/1300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: audit Prometheus data source mutations [rocketmq-dashboard]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #1300:
URL: https://github.com/apache/rocketmq-dashboard/issues/1300#issuecomment-5231676856
## Issue Evaluation
**Category:** `type/enhancement` | **Status:** Evaluated
This is part of a well-structured series to extend `OperationAuditService` coverage across all control-plane mutations.
**Assessment:**
- **Feasibility:** Feasible — reuses existing `OperationAuditService` pattern from `SettingsService`
- **Scope:** Prometheus data source mutations — data-source create, update, and delete
- **Audit Content:** Prometheus-compatible data source metadata (no credentials)
- **Compatibility:** No breaking changes — additive audit records only
- **Testing:** Unit test coverage for success paths + sensitive-value exclusion is appropriate
The design is consistent with the existing audit framework. A PR is welcome.
---
*Automated evaluation by RockteMQ-AI*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: audit Prometheus data source mutations [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #1300:
URL: https://github.com/apache/rocketmq-dashboard/issues/1300#issuecomment-5310383927
This issue has been automatically closed because there has been no activity for 7 days. If you believe this issue is still relevant, please reopen it with updated information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org