[GitHub] [iceberg] steveloughran commented on a change in pull request #2170: Make lookup of data file by file path robust.

[GitBox <gi...@apache.org>]

steveloughran commented on a change in pull request #2170:
URL: https://github.com/apache/iceberg/pull/2170#discussion_r566210134



##########
File path: spark/src/main/java/org/apache/iceberg/spark/source/BaseDataReader.java
##########
@@ -125,11 +126,13 @@ public void close() throws IOException {
 
   protected InputFile getInputFile(FileScanTask task) {
     Preconditions.checkArgument(!task.isDataTask(), "Invalid task type");
-    return inputFiles.get(task.file().path().toString());
+    return getInputFile(task.file().path().toString());

Review comment:
       probably best to path().toURI() for best guarantee of handling of spaces




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org