You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Chunwei Lei (JIRA)" <ji...@apache.org> on 2019/04/18 02:53:00 UTC
[jira] [Comment Edited] (CALCITE-2453) Enhance the SQL parser in
order to optionally support semicolon at the end of the sql statements
[ https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820660#comment-16820660 ]
Chunwei Lei edited comment on CALCITE-2453 at 4/18/19 2:52 AM:
---------------------------------------------------------------
I am not sure that whether we should keep the result before the error statement. For instance, when paring the sql as follows
{code:java}
select * from emp where name like 'toto'; delete from emp delete from emp{code}
the first statement is parsed successfully and the second one failed. Should we keep result of the first statement? Or should we consider it as a failure?
It looks like SQL Server provides many possible outcomes in its batches of sql statements[1]. I prefer to keep the result before the error statement. [~julianhyde], What do you think of it?
[1] [https://docs.microsoft.com/en-us/sql/odbc/reference/develop-app/errors-and-batches?view=sql-server-2017]
was (Author: chunwei lei):
I am not sure that whether we should keep the result before the error statement. For instance, when paring the sql as follows
{code:java}
select * from emp where name like 'toto'; delete from emp delete from emp{code}
the first statement is parsed successfully and the second one failed. Should we keep result of the first statement? Or should we consider it as a failure?
> Enhance the SQL parser in order to optionally support semicolon at the end of the sql statements
> ------------------------------------------------------------------------------------------------
>
> Key: CALCITE-2453
> URL: https://issues.apache.org/jira/browse/CALCITE-2453
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: next
> Reporter: charbel yazbeck
> Assignee: Chunwei Lei
> Priority: Trivial
> Labels: pull-request-available
> Attachments: 0001-CALCITE-2453-Allowing-SQL-statements-to-optionally-e.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Consists of adding [<SEMICOLON>] in Parser.jj
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)