You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2014/04/29 19:37:03 UTC

Review Request 20858: Usability: Different umask can cause a lot of issue when installing - alert when first veriying berforei nstall.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20858/
-----------------------------------------------------------

Review request for Ambari, Sumit Mohanty and Sid Wagle.


Bugs: AMBARI-5621
    https://issues.apache.org/jira/browse/AMBARI-5621


Repository: ambari


Description
-------

Different umask can cause a lot of issue when installing - alert when first veriying berforei nstall.


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/ActionQueue.py 221bf27 
  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java 84e9fbf 
  ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml db03a8b 
  ambari-server/src/main/resources/custom_actions/check_umask.py PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java 97ee040 

Diff: https://reviews.apache.org/r/20858/diff/


Testing
-------

OK
----------------------------------------------------------------------
Total run:548
Total errors:0
Total failures:0
OK


Thanks,

Vitalyi Brodetskyi


Re: Review Request 20858: Usability: Different umask can cause a lot of issue when installing - alert when first veriying berforei nstall.

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20858/#review41729
-----------------------------------------------------------

Ship it!


Ship It!

- Sumit Mohanty


On April 29, 2014, 5:37 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20858/
> -----------------------------------------------------------
> 
> (Updated April 29, 2014, 5:37 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
> 
> 
> Bugs: AMBARI-5621
>     https://issues.apache.org/jira/browse/AMBARI-5621
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Different umask can cause a lot of issue when installing - alert when first veriying berforei nstall.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 221bf27 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java 84e9fbf 
>   ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml db03a8b 
>   ambari-server/src/main/resources/custom_actions/check_umask.py PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java 97ee040 
> 
> Diff: https://reviews.apache.org/r/20858/diff/
> 
> 
> Testing
> -------
> 
> OK
> ----------------------------------------------------------------------
> Total run:548
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 20858: Usability: Different umask can cause a lot of issue when installing - alert when first veriying berforei nstall.

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20858/#review41728
-----------------------------------------------------------



ambari-server/src/main/resources/custom_actions/check_umask.py
<https://reviews.apache.org/r/20858/#comment75316>

    We could take umask to check as an input and have it default to 0022. Lets open a separate task as an improvement that we can commit later.


- Sumit Mohanty


On April 29, 2014, 5:37 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20858/
> -----------------------------------------------------------
> 
> (Updated April 29, 2014, 5:37 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
> 
> 
> Bugs: AMBARI-5621
>     https://issues.apache.org/jira/browse/AMBARI-5621
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Different umask can cause a lot of issue when installing - alert when first veriying berforei nstall.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 221bf27 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java 84e9fbf 
>   ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml db03a8b 
>   ambari-server/src/main/resources/custom_actions/check_umask.py PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java 97ee040 
> 
> Diff: https://reviews.apache.org/r/20858/diff/
> 
> 
> Testing
> -------
> 
> OK
> ----------------------------------------------------------------------
> Total run:548
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 20858: Usability: Different umask can cause a lot of issue when installing - alert when first veriying berforei nstall.

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20858/#review43120
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On May 15, 2014, 3:39 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20858/
> -----------------------------------------------------------
> 
> (Updated May 15, 2014, 3:39 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-5621
>     https://issues.apache.org/jira/browse/AMBARI-5621
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Different umask can cause a lot of issue when installing - alert when first veriying berforei nstall.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml e8d66e7 
>   ambari-server/src/main/resources/custom_actions/check_umask.py fe1c1c6 
> 
> Diff: https://reviews.apache.org/r/20858/diff/
> 
> 
> Testing
> -------
> 
> OK
> ----------------------------------------------------------------------
> Total run:548
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 20858: Usability: Different umask can cause a lot of issue when installing - alert when first veriying berforei nstall.

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20858/
-----------------------------------------------------------

(Updated May 15, 2014, 3:39 p.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-5621
    https://issues.apache.org/jira/browse/AMBARI-5621


Repository: ambari


Description
-------

Different umask can cause a lot of issue when installing - alert when first veriying berforei nstall.


Diffs
-----

  ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml e8d66e7 
  ambari-server/src/main/resources/custom_actions/check_umask.py fe1c1c6 

Diff: https://reviews.apache.org/r/20858/diff/


Testing
-------

OK
----------------------------------------------------------------------
Total run:548
Total errors:0
Total failures:0
OK


Thanks,

Vitalyi Brodetskyi


Re: Review Request 20858: Usability: Different umask can cause a lot of issue when installing - alert when first veriying berforei nstall.

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20858/
-----------------------------------------------------------

(Updated May 15, 2014, 3:39 p.m.)


Review request for Ambari, Sumit Mohanty and Sid Wagle.


Bugs: AMBARI-5621
    https://issues.apache.org/jira/browse/AMBARI-5621


Repository: ambari


Description
-------

Different umask can cause a lot of issue when installing - alert when first veriying berforei nstall.


Diffs (updated)
-----

  ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml e8d66e7 
  ambari-server/src/main/resources/custom_actions/check_umask.py fe1c1c6 

Diff: https://reviews.apache.org/r/20858/diff/


Testing
-------

OK
----------------------------------------------------------------------
Total run:548
Total errors:0
Total failures:0
OK


Thanks,

Vitalyi Brodetskyi