You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "alibabakhanlu12 (via GitHub)" <gi...@apache.org> on 2025/03/30 09:46:05 UTC
[PR] Update apisix-grafana-dashboard.json [apisix]
alibabakhanlu12 opened a new pull request, #12100:
URL: https://github.com/apache/apisix/pull/12100
grafana decrepted all panels that made using angular panels and added react as base framework for new panels. due to that reason i edited this json file and updated new things for supporting react as base library
### Description
i changed the type of panels for supporting react as base framework for all panels
https://grafana.com/developers/plugin-tools/migration-guides/angular-react/
Singlestat → Stat
Graph → Time Series
#### Which issue(s) this PR fixes:
https://grafana.com/docs/grafana/latest/developers/angular_deprecation/
### Checklist
- [*] I have explained the need for this PR and the problem it solves
- [*] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Update apisix-grafana-dashboard.json [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #12100:
URL: https://github.com/apache/apisix/pull/12100#issuecomment-3125891642
Hi @alibabakhanlu12, any updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Update apisix-grafana-dashboard.json [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #12100:
URL: https://github.com/apache/apisix/pull/12100#issuecomment-2857169341
Hi @alibabakhanlu12, after actual manual testing, I found some problems. I used the environment in [apisix-docker ](https://github.com/apache/apisix-docker/blob/master/example/docker-compose.yml)to verify this file and found that the original json file can work properly in subsequent versions(8.x - 12.x). After replacing the new json file, it also works, but some charts are missing units and it seems not as easy to understand as the old one. I feel that this change is unnecessary. What do you think?
|old|new|
|-----|-----|
|<img width="1508" alt="Image" src="https://github.com/user-attachments/assets/d55128d6-8ddd-43a6-865d-a51f9572085e" />|<img width="1510" alt="Image2" src="https://github.com/user-attachments/assets/f4d927c2-4244-47a9-920c-e71f42ba1603" />|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Update apisix-grafana-dashboard.json [apisix]
Posted by "alibabakhanlu12 (via GitHub)" <gi...@apache.org>.
alibabakhanlu12 commented on PR #12100:
URL: https://github.com/apache/apisix/pull/12100#issuecomment-3265736774
If you think the old version is okay, you can close this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Update apisix-grafana-dashboard.json [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #12100:
URL: https://github.com/apache/apisix/pull/12100#issuecomment-2774111772
> Hi @Baoyuantop, any chance to review the changes?
Yes, I'm on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Update apisix-grafana-dashboard.json [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #12100:
URL: https://github.com/apache/apisix/pull/12100#issuecomment-2975449061
I'll convert this PR to draft first, if the changes are done please request review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Update apisix-grafana-dashboard.json [apisix]
Posted by "juzhiyuan (via GitHub)" <gi...@apache.org>.
juzhiyuan commented on PR #12100:
URL: https://github.com/apache/apisix/pull/12100#issuecomment-2788118479
@Baoyuantop good to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Update apisix-grafana-dashboard.json [apisix]
Posted by "juzhiyuan (via GitHub)" <gi...@apache.org>.
juzhiyuan commented on PR #12100:
URL: https://github.com/apache/apisix/pull/12100#issuecomment-2774074264
Hi @Baoyuantop, any chance to review the changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Update apisix-grafana-dashboard.json [apisix]
Posted by "alibabakhanlu12 (via GitHub)" <gi...@apache.org>.
alibabakhanlu12 closed pull request #12100: fix: Update apisix-grafana-dashboard.json
URL: https://github.com/apache/apisix/pull/12100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Update apisix-grafana-dashboard.json [apisix]
Posted by "alibabakhanlu12 (via GitHub)" <gi...@apache.org>.
alibabakhanlu12 commented on PR #12100:
URL: https://github.com/apache/apisix/pull/12100#issuecomment-2779449812
file updated to 2 spaces and can see the changes
@Baoyuantop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org