[GitHub] [tvm] hogepodge commented on a change in pull request #7867: [Runtime] Driver version + consistent clock speed units

[GitBox <gi...@apache.org>]

hogepodge commented on a change in pull request #7867:
URL: https://github.com/apache/tvm/pull/7867#discussion_r616954496



##########
File path: python/tvm/_ffi/runtime_ctypes.py
##########
@@ -205,63 +214,190 @@ def _GetDeviceAttr(self, device_type, device_id, attr_id):
 
     @property
     def exist(self):
-        """Whether this device exist."""
+        """Whether this device exists.
+
+        Returns True if TVM was support for the device, if the

Review comment:
       s/was/has

##########
File path: python/tvm/_ffi/runtime_ctypes.py
##########
@@ -205,63 +214,190 @@ def _GetDeviceAttr(self, device_type, device_id, attr_id):
 
     @property
     def exist(self):
-        """Whether this device exist."""
+        """Whether this device exists.
+
+        Returns True if TVM was support for the device, if the
+        physical device is present, and the device is accessible
+        through appropriate drivers (e.g. cuda/vulkan).
+
+        Returns
+        -------
+        exist : bool
+            Whether the device exists

Review comment:
       s/Whether/True if




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org