You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/07/15 18:32:56 UTC
[GitHub] [solr] HoustonPutman opened a new pull request, #944: SOLR-16298: Clean javadocs directory before building
HoustonPutman opened a new pull request, #944:
URL: https://github.com/apache/solr/pull/944
https://issues.apache.org/jira/browse/SOLR-16298
Steps to reproduce the issue:
1. Check out the 9.0.0 tag
2. `./gradlew documentation`
3. Check out main
4. `./gradlew documentation`
5. `less solr/documentation/build/site/core/org/apache/solr/handler/admin/CoreAdminHandlerApi.html`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on a diff in pull request #944: SOLR-16298: Clean javadocs directory before building
Posted by GitBox <gi...@apache.org>.
madrob commented on code in PR #944:
URL: https://github.com/apache/solr/pull/944#discussion_r922542591
##########
gradle/documentation/render-javadoc.gradle:
##########
@@ -268,6 +268,13 @@ class RenderJavadocTask extends DefaultTask {
// create the directory, so relative link calculation knows that it's a directory:
outputDir.mkdirs();
+ outputDir.listFiles().each {childFile ->
Review Comment:
what about `project.delete`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman merged pull request #944: SOLR-16298: Clean javadocs directory before building
Posted by GitBox <gi...@apache.org>.
HoustonPutman merged PR #944:
URL: https://github.com/apache/solr/pull/944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on a diff in pull request #944: SOLR-16298: Clean javadocs directory before building
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on code in PR #944:
URL: https://github.com/apache/solr/pull/944#discussion_r923637882
##########
gradle/documentation/render-javadoc.gradle:
##########
@@ -268,6 +268,13 @@ class RenderJavadocTask extends DefaultTask {
// create the directory, so relative link calculation knows that it's a directory:
outputDir.mkdirs();
+ outputDir.listFiles().each {childFile ->
Review Comment:
I looked through the lucene implementation but I didn't really see this addressed either. Maybe I missed it though.
Will change to use `project.delete` though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] uschindler commented on a diff in pull request #944: SOLR-16298: Clean javadocs directory before building
Posted by GitBox <gi...@apache.org>.
uschindler commented on code in PR #944:
URL: https://github.com/apache/solr/pull/944#discussion_r922678589
##########
gradle/documentation/render-javadoc.gradle:
##########
@@ -268,6 +268,13 @@ class RenderJavadocTask extends DefaultTask {
// create the directory, so relative link calculation knows that it's a directory:
outputDir.mkdirs();
+ outputDir.listFiles().each {childFile ->
Review Comment:
I agree. This is more Gradle like. You should also check the Lucene version. Maybe it is more up to date in that regard. The version number is an input property there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] uschindler commented on a diff in pull request #944: SOLR-16298: Clean javadocs directory before building
Posted by GitBox <gi...@apache.org>.
uschindler commented on code in PR #944:
URL: https://github.com/apache/solr/pull/944#discussion_r922678428
##########
gradle/documentation/render-javadoc.gradle:
##########
@@ -268,6 +268,13 @@ class RenderJavadocTask extends DefaultTask {
// create the directory, so relative link calculation knows that it's a directory:
outputDir.mkdirs();
+ outputDir.listFiles().each {childFile ->
Review Comment:
No idea why it is this way. Have you checked the Lucene version, it may be more up-to-date.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org