You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@quickstep.apache.org by na...@apache.org on 2016/06/29 17:54:49 UTC
[3/5] incubator-quickstep git commit: Added move semantic in the
constructor of window plan.
Added move semantic in the constructor of window plan.
Project: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/commit/f6f0c8b8
Tree: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/tree/f6f0c8b8
Diff: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/diff/f6f0c8b8
Branch: refs/heads/hashtable_collector
Commit: f6f0c8b8dbebbf9eba1a80fbc9462707090715a4
Parents: f66f4bd
Author: shixuan-fan <sh...@apache.org>
Authored: Tue Jun 28 15:42:09 2016 +0000
Committer: Zuyu Zhang <zu...@apache.org>
Committed: Tue Jun 28 22:08:49 2016 -0700
----------------------------------------------------------------------
query_optimizer/resolver/Resolver.cpp | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-quickstep/blob/f6f0c8b8/query_optimizer/resolver/Resolver.cpp
----------------------------------------------------------------------
diff --git a/query_optimizer/resolver/Resolver.cpp b/query_optimizer/resolver/Resolver.cpp
index 1eb6d86..c07751a 100644
--- a/query_optimizer/resolver/Resolver.cpp
+++ b/query_optimizer/resolver/Resolver.cpp
@@ -228,13 +228,13 @@ struct Resolver::QueryAggregationInfo {
};
struct Resolver::WindowPlan {
- WindowPlan(const E::WindowInfo &window_info_in,
- const L::LogicalPtr &logical_plan_in)
- : window_info(window_info_in),
- logical_plan(logical_plan_in) {}
+ WindowPlan(const L::LogicalPtr &logical_plan_in,
+ E::WindowInfo &&window_info_in) // NOLINT(whitespace/operators)
+ : logical_plan(logical_plan_in),
+ window_info(std::move(window_info_in)) {}
- const E::WindowInfo window_info;
const L::LogicalPtr logical_plan;
+ const E::WindowInfo window_info;
};
struct Resolver::WindowAggregationInfo {
@@ -1032,9 +1032,9 @@ L::LogicalPtr Resolver::resolveSelect(
L::LogicalPtr sorted_logical_plan = resolveSortInWindow(logical_plan,
resolved_window);
- WindowPlan window_plan(resolved_window, sorted_logical_plan);
+ WindowPlan window_plan(sorted_logical_plan, std::move(resolved_window));
- sorted_window_map.emplace(window.name()->value(), window_plan);
+ sorted_window_map.emplace(window.name()->value(), std::move(window_plan));
}
}