[GitHub] [cloudstack] SadiJr commented on a change in pull request #5181: vmware, ui: update portgroup on network offering change

[GitBox <gi...@apache.org>]

SadiJr commented on a change in pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#discussion_r670468794



##########
File path: ui/src/views/AutogenView.vue
##########
@@ -834,6 +834,10 @@ export default {
         params.isofilter = 'executable'
       } else if (possibleApi === 'listHosts') {
         params.type = 'routing'
+      } else if (possibleApi === 'listNetworkOfferings') {
+        if (this.resource && this.resource.type) {

Review comment:
       Wouldn't it be better to add this if to the else statement?
   Like
   ```
   } else if (possibleApi === 'listNetworkOfferings' && (this.resource && this.resource.type)) {
      params.guestiptype = this.resource.type
   }
   ```
   
   Or
   ```
   } else if (possibleApi === 'listNetworkOfferings' && this.resource && this.resource.type) {
      params.guestiptype = this.resource.type
   }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org