You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Keith Wall (JIRA)" <ji...@apache.org> on 2018/03/15 08:55:00 UTC

[jira] [Comment Edited] (QPID-8130) [Broker-J] IAE "Comparison method violates its general contract!" can be thrown whilst comparing log file details of file logger

    [ https://issues.apache.org/jira/browse/QPID-8130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400089#comment-16400089 ] 

Keith Wall edited comment on QPID-8130 at 3/15/18 8:54 AM:
-----------------------------------------------------------

As we are on Java 8, we can use: 
{noformat}
Comparator.comparingLong(LogFileDetails::getLastModified){noformat}
For the record, I checked elsewhere in the Broker-J code base and did not find other occasions where the same mistake is made. 

 


was (Author: k-wall):
As we are on Java 8, we can use: 
{noformat}
Comparator.comparingLong(LogFileDetails::getLastModified){noformat}
 

 

> [Broker-J] IAE "Comparison method violates its general contract!" can be thrown whilst comparing log file details of file logger
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-8130
>                 URL: https://issues.apache.org/jira/browse/QPID-8130
>             Project: Qpid
>          Issue Type: Bug
>          Components: Broker-J
>    Affects Versions: qpid-java-broker-7.0.2, qpid-java-6.0.8, qpid-java-broker-7.0.0, qpid-java-6.1.5, qpid-java-broker-7.0.1
>            Reporter: Alex Rudyy
>            Assignee: Alex Rudyy
>            Priority: Minor
>             Fix For: qpid-java-6.1.6, qpid-java-broker-7.0.3
>
>
> IllegalArgumentException "Comparison method violates its general contract!" can be thrown whilst comparing log file details of BrokerFileLogger or ViortualHostFileLogger
> {noformat}
> 2018-03-14 13:06:57,951 DEBUG [qtp127624166-218] (o.a.q.s.m.p.s.r.RestServlet) - IllegalArgumentException processing request
> java.lang.IllegalArgumentException: Comparison method violates its general contract!
>         at java.util.TimSort.mergeHi(TimSort.java:899)
>         at java.util.TimSort.mergeAt(TimSort.java:516)
>         at java.util.TimSort.mergeForceCollapse(TimSort.java:457)
>         at java.util.TimSort.sort(TimSort.java:254)
>         at java.util.Arrays.sort(Arrays.java:1512)
>         at java.util.ArrayList.sort(ArrayList.java:1454)
>         at java.util.Collections.sort(Collections.java:175)
>         at org.apache.qpid.server.logging.logback.RolloverWatcher.getLogFileDetails(RolloverWatcher.java:130)
>         at org.apache.qpid.server.logging.logback.BrokerFileLoggerImpl.getLogFiles(BrokerFileLoggerImpl.java:156)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.lang.reflect.Method.invoke(Method.java:498)
>         at org.apache.qpid.server.model.ConfiguredObjectMethodAttributeOrStatistic.getValue(ConfiguredObjectMethodAttributeOrStatistic.java:68)
>         at org.apache.qpid.server.model.ConfiguredObjectMethodAttribute.getValue(ConfiguredObjectMethodAttribute.java:26)
>         at org.apache.qpid.server.model.AbstractConfiguredObject.getAttribute(AbstractConfiguredObject.java:1856)
>         at org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.incorporateAttributesIntoMap(ConfiguredObjectToMapConverter.java:86)
>         at org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.convertObjectToMap(ConfiguredObjectToMapConverter.java:64)
>         at org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.incorporateChildrenIntoMap(ConfiguredObjectToMapConverter.java:271)
>         at org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.convertObjectToMap(ConfiguredObjectToMapConverter.java:69)
>         at org.apache.qpid.server.management.plugin.servlet.rest.RestServlet.doGet(RestServlet.java:247)
>         at org.apache.qpid.server.management.plugin.servlet.rest.AbstractServlet.doGet(AbstractServlet.java:128)
>         at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
>         at org.apache.qpid.server.management.plugin.servlet.rest.RestServlet.service(RestServlet.java:341)
>         at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
>         at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:841)
>         at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1634)
>         at org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter$1.run(AuthenticationCheckFilter.java:157)
>         at org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter$1.run(AuthenticationCheckFilter.java:153)
>         at java.security.AccessController.doPrivileged(Native Method)
>         at javax.security.auth.Subject.doAs(Subject.java:422)
>         at org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter.doFilterChainAs(AuthenticationCheckFilter.java:152)
>         at org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter.doFilter(AuthenticationCheckFilter.java:122)
>         at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1621)
>         at org.apache.qpid.server.management.plugin.filter.LoggingFilter.doFilter(LoggingFilter.java:63)
>         at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1621)
>         at org.apache.qpid.server.management.plugin.filter.ForbiddingTraceFilter.doFilter(ForbiddingTraceFilter.java:65)
>         at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1621)
>         at org.eclipse.jetty.servlets.CrossOriginFilter.handle(CrossOriginFilter.java:308)
>         at org.eclipse.jetty.servlets.CrossOriginFilter.doFilter(CrossOriginFilter.java:262)
>         at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1621)
>         at org.apache.qpid.server.management.plugin.filter.ExceptionHandlingFilter.doFilter(ExceptionHandlingFilter.java:59)
>         at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1621)
>         at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:541)
>         at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:188)
>         at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1593)
>         at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:188)
>         at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1239)
>         at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:168)
>         at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:481)
>         at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1562)
>         at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:166)
>         at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1141)
>         at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
>         at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:132)
>         at org.eclipse.jetty.server.Server.handle(Server.java:564)
>         at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:320)
>         at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)
>         at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:279)
>         at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:110)
>         at org.eclipse.jetty.io.ChannelEndPoint$2.run(ChannelEndPoint.java:124)
>         at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:672)
>         at org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:590)
>         at org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.lambda$null$0(QpidByteBufferFactory.java:464)
>         at java.lang.Thread.run(Thread.java:745)
> {noformat}
> The exception can be thrown on attempt to get value of derived attribute {{logFiles}} in {{FileLoger}}. As result, REST calls to {{FileLoger}} can end-up in error as below
> {code:java}
> {
>   "errorMessage" : "Comparison method violates its general contract!"
> }
> {code}
> Broker REST service call can be affected if depth parameter value is 1 or greater.
>  The Web Management Console invokes broker REST service with depth=1 and on running into the issue the information on Broker tab is not rendered.  Otherwise the operation of the Broker is not affected.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org