[GitHub] dg4prez commented on a change in pull request #2158: modifies ORT to correctly parse api 1.3 for revalidation.

[GitBox <gi...@apache.org>]

dg4prez commented on a change in pull request #2158: modifies ORT to correctly parse api 1.3 for revalidation.  
URL: https://github.com/apache/incubator-trafficcontrol/pull/2158#discussion_r183716652
 
 

 ##########
 File path: traffic_ops/bin/traffic_ops_ort.pl
 ##########
 @@ -783,6 +771,53 @@ sub get_print_current_client_connections {
 	( $log_level >> $DEBUG ) && print "DEBUG There are currently $current_connections connections.\n";
 }
 
+sub get_update_status {
+	my $status_api;
+	my $uri     = "/api/1.3/servers/$hostname_short/update_status";
 
 Review comment:
   ORT is not always updated in concert with traffic ops, so the thinking here is to maintain compatibility in both directions, at least for a little while.  Because the 1.3 api did not originally have the field we need to determine instant invalidation, we need that fallback ability.  The only other solution I can think of is to a) increase the api version of that endpoint to 1.4 or b) look for that field within the endpoint and then fail if the new field isn't present.  But ORT will not work without either the old UI endpoint or this fixed 1.3 endpoint at this time.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services