You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/30 22:32:58 UTC
[jira] [Commented] (BEAM-1063) WordCount on DirectRunner is hanging
for ~1 minute after job runs
[ https://issues.apache.org/jira/browse/BEAM-1063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710025#comment-15710025 ]
ASF GitHub Bot commented on BEAM-1063:
--------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/incubator-beam/pull/1470
[BEAM-1063] Shutdown DynamicSplit Executor in Cleanup
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
This ensures that the threads will be shut off when the pipeline shuts
down, enabling a JVM with no more work to do to shut down as well.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/incubator-beam direct_runner_finishes_and_hangs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1470.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1470
----
commit 2780181991afd62093ca79330f95ff7c759c2f6b
Author: Thomas Groh <tg...@google.com>
Date: 2016-11-30T22:30:14Z
Shutdown DynamicSplit Executor in Cleanup
This ensures that the threads will be shut off when the pipeline shuts
down, enabling a JVM with no more work to do to shut down as well.
----
> WordCount on DirectRunner is hanging for ~1 minute after job runs
> -----------------------------------------------------------------
>
> Key: BEAM-1063
> URL: https://issues.apache.org/jira/browse/BEAM-1063
> Project: Beam
> Issue Type: Bug
> Components: runner-direct
> Affects Versions: Not applicable
> Reporter: Daniel Halperin
> Assignee: Thomas Groh
>
> generate example archetype
> {code}
> mvn compile exec:java -Dexec.mainClass=org.apache.beam.examples.WordCount \
> -Dexec.args="--inputFile=pom.xml --output=direct/counts"
> {code}
> In the demo I gave 2 weeks ago (sorry, not sure what commit this was at) this finished quickly.
> In the demo Ben gave yesterday, it hung. But only in the Direct runner. Some regression in that time?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)