[GitHub] [flink-kubernetes-operator] Grypse commented on a diff in pull request #270: [FLINK-28087]Add validation for the meta.name of FlinkDeployment CR.

[GitBox <gi...@apache.org>]

Grypse commented on code in PR #270:
URL: https://github.com/apache/flink-kubernetes-operator/pull/270#discussion_r898752934


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java:
##########
@@ -100,6 +104,21 @@ private static Optional<String> firstPresent(Optional<String>... errOpts) {
         return Optional.empty();
     }
 
+    private Optional<String> validateDeploymentName(String name) {
+        if (name == null) {
+            return Optional.of("FlinkDeployment name must be define.");

Review Comment:
   Ok, I removed the null check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org