You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/08/08 02:43:00 UTC
Review Request 24486: Drop HostAttributes with no slaveId when recovering
from persistent storage.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24486/
-----------------------------------------------------------
Review request for Aurora and Kevin Sweeney.
Bugs: AURORA-641
https://issues.apache.org/jira/browse/AURORA-641
Repository: aurora
Description
-------
Drop HostAttributes with no slaveId when recovering from persistent storage.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 345442035ccfa0a04a92f9eb389add50d0a492d9
src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 5d3ec36d9907be543296847134c53e6ddc6edc70
src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java a9545e1656a3b1b0ae55155eec4f06878158d8da
src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 48600b59b918434ef963b758279c48584ccd34ef
Diff: https://reviews.apache.org/r/24486/diff/
Testing
-------
./gradlew build -Pq
Thanks,
Bill Farner
Re: Review Request 24486: Drop HostAttributes with no slaveId when
recovering from persistent storage.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24486/#review49992
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java
<https://reviews.apache.org/r/24486/#comment87448>
LOG.warning() here and below?
- Maxim Khutornenko
On Aug. 8, 2014, 12:42 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24486/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2014, 12:42 a.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-641
> https://issues.apache.org/jira/browse/AURORA-641
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Drop HostAttributes with no slaveId when recovering from persistent storage.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 345442035ccfa0a04a92f9eb389add50d0a492d9
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 5d3ec36d9907be543296847134c53e6ddc6edc70
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java a9545e1656a3b1b0ae55155eec4f06878158d8da
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 48600b59b918434ef963b758279c48584ccd34ef
>
> Diff: https://reviews.apache.org/r/24486/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 24486: Drop HostAttributes with no slaveId when
recovering from persistent storage.
Posted by Bill Farner <wf...@apache.org>.
> On Aug. 8, 2014, 12:45 a.m., Kevin Sweeney wrote:
> > Any reason to do this at write-time instead of boot-time via StorageBackfill?
Yes - backfill doesn't help here since it's a step between recovered storage and exposure of state. The error we encounter is during storage population.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24486/#review49987
-----------------------------------------------------------
On Aug. 8, 2014, 12:42 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24486/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2014, 12:42 a.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-641
> https://issues.apache.org/jira/browse/AURORA-641
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Drop HostAttributes with no slaveId when recovering from persistent storage.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 345442035ccfa0a04a92f9eb389add50d0a492d9
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 5d3ec36d9907be543296847134c53e6ddc6edc70
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java a9545e1656a3b1b0ae55155eec4f06878158d8da
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 48600b59b918434ef963b758279c48584ccd34ef
>
> Diff: https://reviews.apache.org/r/24486/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 24486: Drop HostAttributes with no slaveId when
recovering from persistent storage.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24486/#review49987
-----------------------------------------------------------
Any reason to do this at write-time instead of boot-time via StorageBackfill?
- Kevin Sweeney
On Aug. 7, 2014, 5:42 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24486/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2014, 5:42 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-641
> https://issues.apache.org/jira/browse/AURORA-641
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Drop HostAttributes with no slaveId when recovering from persistent storage.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 345442035ccfa0a04a92f9eb389add50d0a492d9
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 5d3ec36d9907be543296847134c53e6ddc6edc70
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java a9545e1656a3b1b0ae55155eec4f06878158d8da
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 48600b59b918434ef963b758279c48584ccd34ef
>
> Diff: https://reviews.apache.org/r/24486/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 24486: Drop HostAttributes with no slaveId when
recovering from persistent storage.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24486/#review49993
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Aug. 7, 2014, 5:42 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24486/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2014, 5:42 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-641
> https://issues.apache.org/jira/browse/AURORA-641
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Drop HostAttributes with no slaveId when recovering from persistent storage.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 345442035ccfa0a04a92f9eb389add50d0a492d9
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 5d3ec36d9907be543296847134c53e6ddc6edc70
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java a9545e1656a3b1b0ae55155eec4f06878158d8da
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 48600b59b918434ef963b758279c48584ccd34ef
>
> Diff: https://reviews.apache.org/r/24486/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Bill Farner
>
>