You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/30 06:15:20 UTC

[GitHub] [beam] youngoli commented on pull request #11870: [BEAM-9951] Adding integration tests for synthetic pipelines in Go (IN-PROGRESS)

youngoli commented on pull request #11870:
URL: https://github.com/apache/beam/pull/11870#issuecomment-636284163


   As a note for what still needs to be done:
   * Unit tests for this code
   * I'd like to separate the CountElms aggregation into Beam, alongside the existing Count (which works per-key).
   * The count PAssert needs to be changed to have its own error message, instead of using passert.Equals. From personal experience, using the passert.Equals error message is really unclear when there's an error.
   
   CC: @lostluck Take a look if you want, but don't worry about reviewing yet.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org