You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/05/08 15:40:25 UTC
Review Request 59051: Integrate Log Search integration test framework
with Selenium
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59051/
-----------------------------------------------------------
Review request for Ambari, Laszlo Puskas, Miklos Gergely, Robert Nettleton, Sandor Magyari, and Sebastian Toader.
Bugs: AMBARI-20955
https://issues.apache.org/jira/browse/AMBARI-20955
Repository: ambari
Description
-------
Integrate selenium with log search it framework.
Tests can be run separately for ui and backend. Currently it requires x11 forwarding to see the tests itself. (later headless will be added). Also im using localhost as docker hosts right now, which means it currenty works with docker-for-mac or on linux system with an installed docker
Diffs
-----
ambari-logsearch/README.md 5c41fcd
ambari-logsearch/ambari-logsearch-it/pom.xml ee97e99
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/domain/StoryDataRegistry.java cb72376
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/AbstractLogSearchSteps.java PRE-CREATION
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchDockerSteps.java 32e8cba
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchUISteps.java PRE-CREATION
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchApiQueryStory.java 45455bf
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchBackendStories.java PRE-CREATION
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchStory.java ce6b9cb
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchUIStories.java PRE-CREATION
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogfeederParsingStory.java c502cc4
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/web/AbstractPage.java PRE-CREATION
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/web/Home.java PRE-CREATION
ambari-logsearch/ambari-logsearch-it/src/test/resources/org/apache/ambari/logsearch/story/log_search_api_query_story.story cfaa359
ambari-logsearch/ambari-logsearch-it/src/test/resources/org/apache/ambari/logsearch/story/logfeeder_parsing_story.story 388e624
ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/log_search_api_query_story.story PRE-CREATION
ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/logfeeder_parsing_story.story PRE-CREATION
ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/selenium/login.ui.story PRE-CREATION
ambari-logsearch/docker/Dockerfile 6e8ea3e
ambari-logsearch/docker/bin/start.sh 1efc85c
ambari-logsearch/docker/logsearch-docker.sh eab850e
Diff: https://reviews.apache.org/r/59051/diff/1/
Testing
-------
ran with -Dselenium-tests and with -Dbackend-tests as well
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:36 min
[INFO] Finished at: 2017-05-08T16:27:44+02:00
[INFO] Final Memory: 51M/499M
[INFO] ------------------------------------------------------------------------
Thanks,
Oliver Szabo
Re: Review Request 59051: Integrate Log Search integration test
framework with Selenium
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59051/#review174291
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On May 9, 2017, 11:59 a.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59051/
> -----------------------------------------------------------
>
> (Updated May 9, 2017, 11:59 a.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Miklos Gergely, Robert Nettleton, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-20955
> https://issues.apache.org/jira/browse/AMBARI-20955
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Integrate selenium with log search it framework.
> Tests can be run separately for ui and backend. Currently it requires x11 forwarding to see the tests itself. (later headless will be added). Also im using localhost as docker hosts right now, which means it currenty works with docker-for-mac or on linux system with an installed docker
>
>
> Diffs
> -----
>
> ambari-logsearch/README.md 5c41fcd
> ambari-logsearch/ambari-logsearch-it/pom.xml ee97e99
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/domain/StoryDataRegistry.java cb72376
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/AbstractLogSearchSteps.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchDockerSteps.java 32e8cba
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchUISteps.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchApiQueryStory.java 45455bf
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchBackendStories.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchStory.java ce6b9cb
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchUIStories.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogfeederParsingStory.java c502cc4
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/web/AbstractPage.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/web/Home.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-it/src/test/resources/org/apache/ambari/logsearch/story/log_search_api_query_story.story cfaa359
> ambari-logsearch/ambari-logsearch-it/src/test/resources/org/apache/ambari/logsearch/story/logfeeder_parsing_story.story 388e624
> ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/log_search_api_query_story.story PRE-CREATION
> ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/logfeeder_parsing_story.story PRE-CREATION
> ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/selenium/login.ui.story PRE-CREATION
> ambari-logsearch/docker/Dockerfile 6e8ea3e
> ambari-logsearch/docker/bin/start.sh 1efc85c
> ambari-logsearch/docker/logsearch-docker.sh eab850e
>
>
> Diff: https://reviews.apache.org/r/59051/diff/2/
>
>
> Testing
> -------
>
> ran with -Dselenium-tests and with -Dbackend-tests as well
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:36 min
> [INFO] Finished at: 2017-05-08T16:27:44+02:00
> [INFO] Final Memory: 51M/499M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 59051: Integrate Log Search integration test
framework with Selenium
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59051/
-----------------------------------------------------------
(Updated May 9, 2017, 9:59 a.m.)
Review request for Ambari, Laszlo Puskas, Miklos Gergely, Robert Nettleton, Sandor Magyari, and Sebastian Toader.
Changes
-------
remove unnecessary docker initialization
Bugs: AMBARI-20955
https://issues.apache.org/jira/browse/AMBARI-20955
Repository: ambari
Description
-------
Integrate selenium with log search it framework.
Tests can be run separately for ui and backend. Currently it requires x11 forwarding to see the tests itself. (later headless will be added). Also im using localhost as docker hosts right now, which means it currenty works with docker-for-mac or on linux system with an installed docker
Diffs (updated)
-----
ambari-logsearch/README.md 5c41fcd
ambari-logsearch/ambari-logsearch-it/pom.xml ee97e99
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/domain/StoryDataRegistry.java cb72376
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/AbstractLogSearchSteps.java PRE-CREATION
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchDockerSteps.java 32e8cba
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchUISteps.java PRE-CREATION
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchApiQueryStory.java 45455bf
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchBackendStories.java PRE-CREATION
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchStory.java ce6b9cb
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchUIStories.java PRE-CREATION
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogfeederParsingStory.java c502cc4
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/web/AbstractPage.java PRE-CREATION
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/web/Home.java PRE-CREATION
ambari-logsearch/ambari-logsearch-it/src/test/resources/org/apache/ambari/logsearch/story/log_search_api_query_story.story cfaa359
ambari-logsearch/ambari-logsearch-it/src/test/resources/org/apache/ambari/logsearch/story/logfeeder_parsing_story.story 388e624
ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/log_search_api_query_story.story PRE-CREATION
ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/logfeeder_parsing_story.story PRE-CREATION
ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/selenium/login.ui.story PRE-CREATION
ambari-logsearch/docker/Dockerfile 6e8ea3e
ambari-logsearch/docker/bin/start.sh 1efc85c
ambari-logsearch/docker/logsearch-docker.sh eab850e
Diff: https://reviews.apache.org/r/59051/diff/2/
Changes: https://reviews.apache.org/r/59051/diff/1-2/
Testing
-------
ran with -Dselenium-tests and with -Dbackend-tests as well
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:36 min
[INFO] Finished at: 2017-05-08T16:27:44+02:00
[INFO] Final Memory: 51M/499M
[INFO] ------------------------------------------------------------------------
Thanks,
Oliver Szabo
Re: Review Request 59051: Integrate Log Search integration test
framework with Selenium
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59051/#review174182
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On May 8, 2017, 3:40 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59051/
> -----------------------------------------------------------
>
> (Updated May 8, 2017, 3:40 p.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Miklos Gergely, Robert Nettleton, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-20955
> https://issues.apache.org/jira/browse/AMBARI-20955
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Integrate selenium with log search it framework.
> Tests can be run separately for ui and backend. Currently it requires x11 forwarding to see the tests itself. (later headless will be added). Also im using localhost as docker hosts right now, which means it currenty works with docker-for-mac or on linux system with an installed docker
>
>
> Diffs
> -----
>
> ambari-logsearch/README.md 5c41fcd
> ambari-logsearch/ambari-logsearch-it/pom.xml ee97e99
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/domain/StoryDataRegistry.java cb72376
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/AbstractLogSearchSteps.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchDockerSteps.java 32e8cba
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchUISteps.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchApiQueryStory.java 45455bf
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchBackendStories.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchStory.java ce6b9cb
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchUIStories.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogfeederParsingStory.java c502cc4
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/web/AbstractPage.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/web/Home.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-it/src/test/resources/org/apache/ambari/logsearch/story/log_search_api_query_story.story cfaa359
> ambari-logsearch/ambari-logsearch-it/src/test/resources/org/apache/ambari/logsearch/story/logfeeder_parsing_story.story 388e624
> ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/log_search_api_query_story.story PRE-CREATION
> ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/logfeeder_parsing_story.story PRE-CREATION
> ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/selenium/login.ui.story PRE-CREATION
> ambari-logsearch/docker/Dockerfile 6e8ea3e
> ambari-logsearch/docker/bin/start.sh 1efc85c
> ambari-logsearch/docker/logsearch-docker.sh eab850e
>
>
> Diff: https://reviews.apache.org/r/59051/diff/1/
>
>
> Testing
> -------
>
> ran with -Dselenium-tests and with -Dbackend-tests as well
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:36 min
> [INFO] Finished at: 2017-05-08T16:27:44+02:00
> [INFO] Final Memory: 51M/499M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Oliver Szabo
>
>