[GitHub] [jackrabbit-oak] klcodanr commented on a change in pull request #516: OAK-9723 Allow comparing index definitions against a file

[GitBox <gi...@apache.org>]

klcodanr commented on a change in pull request #516:
URL: https://github.com/apache/jackrabbit-oak/pull/516#discussion_r825920169



##########
File path: oak-run/src/main/java/org/apache/jackrabbit/oak/index/merge/IndexDiff.java
##########
@@ -192,7 +192,17 @@ private static JsonObject addParent(String key, JsonObject obj) {
     static JsonObject compareIndexes(String directory, String index1, String index2) {
         Path indexPath = Paths.get(directory);
         JsonObject target = new JsonObject(true);
-        compareIndexesIndexesInDirectory(indexPath, index1, index2, target);
+        compareIndexesInDirectory(indexPath, index1, index2, target);
+        return target;
+    }
+
+    public static JsonObject compareIndexesAgainstBase(String directory, String indexBaseFile) {

Review comment:
       Would it make sense to allow setting an output stream for the diff? That way you could either pipe it to standard out or write the diff to a file for further analysis. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org