You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/06 11:30:56 UTC
[GitHub] [flink] TisonKun commented on a change in pull request #10069:
[FLINK-14593][client] Port ClusterClient to asynchronous interface version
TisonKun commented on a change in pull request #10069: [FLINK-14593][client] Port ClusterClient to asynchronous interface version
URL: https://github.com/apache/flink/pull/10069#discussion_r343046157
##########
File path: flink-clients/src/main/java/org/apache/flink/client/program/MiniClusterClient.java
##########
@@ -120,7 +135,25 @@ public String stopWithSavepoint(JobID jobId, boolean advanceToEndOfEventTime, @N
@Override
public String getWebInterfaceURL() {
- return miniCluster.getRestAddress().toString();
+ try {
+ return miniCluster.getRestAddress().get().toString();
+ } catch (InterruptedException | ExecutionException e) {
+ ExceptionUtils.checkInterrupted(e);
+
+ LOG.warn("Could not retrieve the web interface URL for the cluster.", e);
+ return "Unknown address.";
+ }
+ }
+
+ @Override
+ public void shutDownCluster() {
Review comment:
OK. I will add a default "implementation" throw an `UnsupportedOperationException` in this pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services