[GitHub] [carbondata] ravipesala commented on a change in pull request #3731: [CARBONDATA-3786] presto carbon reader should use tablePath from hive catalog

[GitBox <gi...@apache.org>]

ravipesala commented on a change in pull request #3731:
URL: https://github.com/apache/carbondata/pull/3731#discussion_r422159455



##########
File path: integration/presto/src/main/prestodb/org/apache/carbondata/presto/CarbondataSplitManager.java
##########
@@ -109,8 +109,15 @@ public ConnectorSplitSource getSplits(ConnectorTransactionHandle transactionHand
     if (!table.getStorage().getStorageFormat().getInputFormat().contains("carbon")) {
       return super.getSplits(transactionHandle, session, layoutHandle, splitSchedulingStrategy);
     }
-    String location = table.getStorage().getLocation();
-
+    String location;
+    String tablePath = table.getStorage().getSerdeParameters().get("tablePath");

Review comment:
       it is better like 
   ```
   String location = table.getStorage().getSerdeParameters().get("tablePath");
   if (StringUtils.isEmpty(location))  {
      location = table.getStorage().getLocation();
   }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org