[GitHub] [tvm] jcf94 commented on a change in pull request #8897: Add sse4/avx2 support for fast x86 int8 (vpmaddubsw/vpmaddwd/vpaddd)

[GitBox <gi...@apache.org>]

jcf94 commented on a change in pull request #8897:
URL: https://github.com/apache/tvm/pull/8897#discussion_r701523344



##########
File path: tests/python/relay/test_op_level2.py
##########
@@ -1687,7 +1692,7 @@ def _has_fast_int8_instructions(asm, target):
             dtypes=fast_int8_dtypes,
         )
         # Check that vector int mult and add instructions are generated.
-        assert "vpmulld" in asm and "vpadd" in asm
+        assert "pmulhw" in asm and "paddd" in asm

Review comment:
       I'm not so familiar the specific instructions, does `pmulhw` and `paddd` still be vectorize instructions in this test?

##########
File path: python/tvm/topi/x86/utils.py
##########
@@ -18,9 +18,95 @@
 import tvm
 
 
-def get_fp32_len():
+def target_has_sse42(target):

Review comment:
       Just curious about why it's named `sse42` ... Is it for `sse4 & avx2` like the pr title, or minor version like `sse 4.2`?
   
   And an unimportant suggestion which you can ignore is to merge all of these functions below to something like `target_has_attr(target, attr)` and list the candidates of attr in the doc string.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org