You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Kamesh Jayachandran <ka...@collab.net> on 2010/12/08 16:02:23 UTC

ambient_depth_filter_editor is not ignoring 'SVN_ERR_WC_PATH_NOT_FOUND' errors.

Hi All,

Prabhu got stuck with his upcoming default 'send-copy-args=True' work 
for his diff enhancements.

Basically he got diff-tests-44 to fail due to 
"ambient_depth_filter_editor is *not* ignoring 
'SVN_ERR_WC_PATH_NOT_FOUND' errors."

I could see many other callers ignoring the errors 
'SVN_ERR_WC_PATH_NOT_FOUND' especially when it is returned by 
svn_wc__db_read_info(Ex subversion/libsvn_wc/diff.c:close_file).

I guess ambient_depth_filter_editor's close_file can also behave like 
others.

I lack a context to justify this fix, here right now.

I am yet to run full testsuite, I ran only diff_tests with this patch 
and Prabhu's patch it passes.

Any thoughts?

With regards
Kamesh Jayachandran



Re: ambient_depth_filter_editor is not ignoring 'SVN_ERR_WC_PATH_NOT_FOUND' errors.

Posted by "C. Michael Pilato" <cm...@collab.net>.
On 12/08/2010 11:02 AM, Kamesh Jayachandran wrote:
> Hi All,
> 
> Prabhu got stuck with his upcoming default 'send-copy-args=True' work
> for his diff enhancements.
> 
> Basically he got diff-tests-44 to fail due to
> "ambient_depth_filter_editor is *not* ignoring
> 'SVN_ERR_WC_PATH_NOT_FOUND' errors."

The ambient depth filter editor is wrapping editor with no real logic except
that which helps it to avoid calling its wrapped editor due to ambient depth
values.  It is wrong for that editor to be aware of and mask any error
returned from the wrapping editor.  If it was able to successfully call
open_file() or add_file() in the wrapped editor, it's reasonable to expect
that close_file() is also a legitimate function to call.

-1 on this patch.

-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand