You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@sentry.apache.org by "Shreepadma Venugopalan (JIRA)" <ji...@apache.org> on 2014/03/13 20:59:42 UTC

[jira] [Comment Edited] (SENTRY-143) Merge db_policy_store branch into master

    [ https://issues.apache.org/jira/browse/SENTRY-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13933955#comment-13933955 ] 

Shreepadma Venugopalan edited comment on SENTRY-143 at 3/13/14 7:59 PM:
------------------------------------------------------------------------

I looked over the patch, seems alright. The patch is too large for a thorough  review, but I guess that's not the goal of this review.


was (Author: shreepadma):
I looked over the patch, seems alright. The patch is too large for a through review, but I guess that's not the goal of this review.

> Merge db_policy_store branch into master
> ----------------------------------------
>
>                 Key: SENTRY-143
>                 URL: https://issues.apache.org/jira/browse/SENTRY-143
>             Project: Sentry
>          Issue Type: Sub-task
>            Reporter: Shreepadma Venugopalan
>            Assignee: Brock Noland
>         Attachments: SENTRY-143-no-thrift.patch, SENTRY-143.patch
>
>
> We'll do this as a patch to ensure we don't get a merge commit on master. It's important to note that since db_policy_store uses java 7 and we haven't got precommit tests using java 7 yet, this will disable precommit tests, which I think is fine, for now.



--
This message was sent by Atlassian JIRA
(v6.2#6252)