You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "RunyaoChen (via GitHub)" <gi...@apache.org> on 2023/07/17 19:40:52 UTC

[GitHub] [spark] RunyaoChen commented on a diff in pull request #42034: [SPARK-44455][SQL] Quote identifiers with backticks in SHOW CREATE TABLE result

RunyaoChen commented on code in PR #42034:
URL: https://github.com/apache/spark/pull/42034#discussion_r1265820450


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala:
##########
@@ -456,7 +456,7 @@ class DataSourceV2Strategy(session: SparkSession) extends Strategy with Predicat
       if (asSerde) {
         throw QueryCompilationErrors.showCreateTableAsSerdeNotSupportedForV2TablesError()
       }
-      ShowCreateTableExec(output, rt.table) :: Nil
+      ShowCreateTableExec(output, rt.table, rt.name) :: Nil

Review Comment:
   Done. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org