You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@helix.apache.org by jx...@apache.org on 2020/08/04 21:14:46 UTC
[helix] 10/10: Change the logs to address new changes
This is an automated email from the ASF dual-hosted git repository.
jxue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/helix.git
commit 5f6d1eb0efdbd4bb750e0d32863406ca065b1648
Author: Ali Reza Zamani Zadeh Najari <an...@linkedin.com>
AuthorDate: Tue Aug 4 09:42:33 2020 -0700
Change the logs to address new changes
In this commit, some of the inaccurate logs have been modified.
---
.../src/main/java/org/apache/helix/task/AssignableInstanceManager.java | 2 +-
helix-core/src/main/java/org/apache/helix/task/TaskUtil.java | 2 +-
.../java/org/apache/helix/integration/task/TestJobQueueCleanUp.java | 1 -
3 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/helix-core/src/main/java/org/apache/helix/task/AssignableInstanceManager.java b/helix-core/src/main/java/org/apache/helix/task/AssignableInstanceManager.java
index cca9335..e42659c 100644
--- a/helix-core/src/main/java/org/apache/helix/task/AssignableInstanceManager.java
+++ b/helix-core/src/main/java/org/apache/helix/task/AssignableInstanceManager.java
@@ -267,7 +267,7 @@ public class AssignableInstanceManager {
}
}
LOG.info(
- "AssignableInstanceManager built AssignableInstances from scratch based on contexts in TaskDataCache due to Controller switch or ClusterConfig change.");
+ "AssignableInstanceManager built AssignableInstances from scratch based on CurrentState.");
computeGlobalThreadBasedCapacity();
}
diff --git a/helix-core/src/main/java/org/apache/helix/task/TaskUtil.java b/helix-core/src/main/java/org/apache/helix/task/TaskUtil.java
index e6e792f..1edc8a6 100644
--- a/helix-core/src/main/java/org/apache/helix/task/TaskUtil.java
+++ b/helix-core/src/main/java/org/apache/helix/task/TaskUtil.java
@@ -1063,7 +1063,7 @@ public class TaskUtil {
for (String workflowName : toBePurgedWorkflows) {
LOG.warn(
- "WorkflowContext exists for workflow {}. However, Workflow Config is missing! Deleting the WorkflowConfig and IdealState!!",
+ "WorkflowContext exists for workflow {}. However, Workflow Config is missing! Deleting the WorkflowContext and IdealState!!",
workflowName);
// TODO: We dont need this in the future when TF is not relying on IS/EV anymore.
diff --git a/helix-core/src/test/java/org/apache/helix/integration/task/TestJobQueueCleanUp.java b/helix-core/src/test/java/org/apache/helix/integration/task/TestJobQueueCleanUp.java
index ba4fb44..cfa341a 100644
--- a/helix-core/src/test/java/org/apache/helix/integration/task/TestJobQueueCleanUp.java
+++ b/helix-core/src/test/java/org/apache/helix/integration/task/TestJobQueueCleanUp.java
@@ -109,7 +109,6 @@ public class TestJobQueueCleanUp extends TaskTestBase {
Assert
.assertTrue(TestHelper.verify(() -> {
WorkflowConfig config = _driver.getWorkflowConfig(queueName);
- System.out.println("|Current time: " + System.currentTimeMillis() +" **TEST: " + config.getJobDag().getAllNodes());
return config.getJobDag().getAllNodes().equals(remainJobs);
}, TestHelper.WAIT_DURATION));