You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/08/13 14:09:32 UTC
[GitHub] [ratis] SzyWilliam opened a new pull request, #712: RATIS-1671. Add manual trigger snapshot
SzyWilliam opened a new pull request, #712:
URL: https://github.com/apache/ratis/pull/712
## What changes were proposed in this pull request?
Add a interface in `LogAppender` to enable trigger snapshot manually and immediately.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1671
## How was this patch tested?
unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] SzyWilliam commented on pull request #712: RATIS-1671. Add manual trigger snapshot
Posted by GitBox <gi...@apache.org>.
SzyWilliam commented on PR #712:
URL: https://github.com/apache/ratis/pull/712#issuecomment-1228597622
@szetszwo Thanks for the reviews! I've made corresponding changes. However, if we have a function return type `Void` and return value `null`, `Optional.map` will return Optional.Empty, and `isPresent` on Empty will return false. Therefore, I have the previous code `return true` unmodified so that `sent` is properly assigned. Please take a look at it~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo merged pull request #712: RATIS-1671. Add manual trigger snapshot
Posted by GitBox <gi...@apache.org>.
szetszwo merged PR #712:
URL: https://github.com/apache/ratis/pull/712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo commented on a diff in pull request #712: RATIS-1671. Add manual trigger snapshot
Posted by GitBox <gi...@apache.org>.
szetszwo commented on code in PR #712:
URL: https://github.com/apache/ratis/pull/712#discussion_r945209289
##########
ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcLogAppender.java:
##########
@@ -204,6 +207,11 @@ public boolean shouldSendAppendEntries() {
return appendLogRequestObserver == null || super.shouldSendAppendEntries();
}
+ @Override
+ public void sendAppendEntriesNow() throws IOException {
+ sendAppendEntries(true);
Review Comment:
Only run() should send appendEntries. Otherwise, there are synchronization issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-1671. Add manual trigger snapshot [ratis]
Posted by "symious (via GitHub)" <gi...@apache.org>.
symious commented on PR #712:
URL: https://github.com/apache/ratis/pull/712#issuecomment-1982613140
Title and description should be changed to "trigger heartbeat" instead of "trigger snapshot".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-1671. Trigger to send a heartbeat immediately [ratis]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #712:
URL: https://github.com/apache/ratis/pull/712#issuecomment-1984277311
@symious Updated. Thanks for catching it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org