You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/02 10:04:12 UTC

[GitHub] [apisix] hnlq715 opened a new issue #3496: feat: support grpc proxy with insecure mode

hnlq715 opened a new issue #3496:
URL: https://github.com/apache/apisix/issues/3496


   I checked the current implementation only support grpc proxy with ssl?
   
   In my case, we want to use apisix to balance grpc traffic with insecure in intranet environment.
   
   Is there any reason not to support grpc without ssl enabled? Looking forward to your reply :-)
   ```
           {% if ssl.enable then %}
           {% for _, port in ipairs(ssl.listen_port) do %}
           listen [::]:{* port *} ssl {% if ssl.enable_http2 then %} http2 {% end %} {% if enable_reuseport then %} reuseport {% end %};
           {% end %}
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on issue #3496: feat: support grpc proxy with insecure mode

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #3496:
URL: https://github.com/apache/apisix/issues/3496#issuecomment-771535932


   Maybe we can allow plaintext HTTP2?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on issue #3496: feat: support grpc proxy with insecure mode

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #3496:
URL: https://github.com/apache/apisix/issues/3496#issuecomment-773126139


   We should support current way too.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on issue #3496: feat: support grpc proxy with insecure mode

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #3496:
URL: https://github.com/apache/apisix/issues/3496#issuecomment-773126139


   We should support current way too.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] nic-chen commented on issue #3496: feat: support grpc proxy with insecure mode

Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #3496:
URL: https://github.com/apache/apisix/issues/3496#issuecomment-771688374


   @hnlq715  PR is welcome.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] tokers commented on issue #3496: feat: support grpc proxy with insecure mode

Posted by GitBox <gi...@apache.org>.
tokers commented on issue #3496:
URL: https://github.com/apache/apisix/issues/3496#issuecomment-772960901


   > > Seems like nginx do not support h2c and http1 on the same port without ssl...
   > 
   > confirm this ^_^
   
   That's true, we cannot use same port for both http/1.1 and http2 if we don't use TLS/SSL.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] hnlq715 commented on issue #3496: feat: support grpc proxy with insecure mode

Posted by GitBox <gi...@apache.org>.
hnlq715 commented on issue #3496:
URL: https://github.com/apache/apisix/issues/3496#issuecomment-772204209


   @spacewander @nic-chen 
   Seems like nginx do not support h2c and http1 on the same port without ssl...
   So, maybe we need to add a new port for this?
   
   nginx issue:
   https://trac.nginx.org/nginx/ticket/816
   
   without ssl:
   ```
   https://github.com/nginx/nginx/blob/9e07862d6e9d37041a42bbfa34dd1f56ed547505/src/http/ngx_http_request.c#L324-L331
   ```
   
   with ssl:
   ```
   https://github.com/nginx/nginx/blob/9e07862d6e9d37041a42bbfa34dd1f56ed547505/src/http/ngx_http_request.c#L812-L831
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] hnlq715 commented on issue #3496: feat: support grpc proxy with insecure mode

Posted by GitBox <gi...@apache.org>.
hnlq715 commented on issue #3496:
URL: https://github.com/apache/apisix/issues/3496#issuecomment-771554988


   > Maybe we can allow plaintext HTTP2?
   
   That's it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] hnlq715 commented on issue #3496: feat: support grpc proxy with insecure mode

Posted by GitBox <gi...@apache.org>.
hnlq715 commented on issue #3496:
URL: https://github.com/apache/apisix/issues/3496#issuecomment-773111458


   > Maybe we can extend the array format of `node_listen`, allow providing http2 flag?
   > 
   > https://github.com/apache/apisix/blob/1e35cc00eb1df21ee2e826f010c7e1ea35de8ef0/conf/config-default.yaml#L23
   
   It’s good if we do not need to consider compatibility 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander closed issue #3496: feat: support grpc proxy with insecure mode

Posted by GitBox <gi...@apache.org>.
spacewander closed issue #3496:
URL: https://github.com/apache/apisix/issues/3496


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] hnlq715 commented on issue #3496: feat: support grpc proxy with insecure mode

Posted by GitBox <gi...@apache.org>.
hnlq715 commented on issue #3496:
URL: https://github.com/apache/apisix/issues/3496#issuecomment-773111458


   > Maybe we can extend the array format of `node_listen`, allow providing http2 flag?
   > 
   > https://github.com/apache/apisix/blob/1e35cc00eb1df21ee2e826f010c7e1ea35de8ef0/conf/config-default.yaml#L23
   
   It’s good if we do not need to consider compatibility 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] membphis commented on issue #3496: feat: support grpc proxy with insecure mode

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #3496:
URL: https://github.com/apache/apisix/issues/3496#issuecomment-772629577


   > Seems like nginx do not support h2c and http1 on the same port without ssl...
   
   confirm this ^_^


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on issue #3496: feat: support grpc proxy with insecure mode

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #3496:
URL: https://github.com/apache/apisix/issues/3496#issuecomment-772965335


   Maybe we can extend the array format of `node_listen`, allow providing http2 flag?
   https://github.com/apache/apisix/blob/1e35cc00eb1df21ee2e826f010c7e1ea35de8ef0/conf/config-default.yaml#L23


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on issue #3496: feat: support grpc proxy with insecure mode

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #3496:
URL: https://github.com/apache/apisix/issues/3496#issuecomment-771535932


   Maybe we can allow plaintext HTTP2?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] tokers commented on issue #3496: feat: support grpc proxy with insecure mode

Posted by GitBox <gi...@apache.org>.
tokers commented on issue #3496:
URL: https://github.com/apache/apisix/issues/3496#issuecomment-773061452


   > Maybe we can extend the array format of `node_listen`, allow providing http2 flag?
   
   That's good.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on issue #3496: feat: support grpc proxy with insecure mode

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #3496:
URL: https://github.com/apache/apisix/issues/3496#issuecomment-781741712


   Solved.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] tokers commented on issue #3496: feat: support grpc proxy with insecure mode

Posted by GitBox <gi...@apache.org>.
tokers commented on issue #3496:
URL: https://github.com/apache/apisix/issues/3496#issuecomment-773061452


   > Maybe we can extend the array format of `node_listen`, allow providing http2 flag?
   
   That's good.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] nic-chen commented on issue #3496: feat: support grpc proxy with insecure mode

Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #3496:
URL: https://github.com/apache/apisix/issues/3496#issuecomment-771688374


   @hnlq715  PR is welcome.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] hnlq715 commented on issue #3496: feat: support grpc proxy with insecure mode

Posted by GitBox <gi...@apache.org>.
hnlq715 commented on issue #3496:
URL: https://github.com/apache/apisix/issues/3496#issuecomment-771554988


   > Maybe we can allow plaintext HTTP2?
   
   That's it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org