You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Savalek <gi...@git.apache.org> on 2018/09/12 11:16:12 UTC
[GitHub] zeppelin pull request #3179: [ZEPPELIN-3773] - add check permission on write...
GitHub user Savalek opened a pull request:
https://github.com/apache/zeppelin/pull/3179
[ZEPPELIN-3773] - add check permission on write.
### What is this PR for?
Sometimes when drawing the result of a paragraph, a call is made commit paragraph. And if the user does not have permission on write paragraph a window appears with a warning.
This PR fix it.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
[ZEPPELIN-3773](https://issues.apache.org/jira/browse/ZEPPELIN-3773)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3773
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3179.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3179
----
commit 116ada702f4e2fc2b902b6982e097ec5672695c6
Author: Savalek <de...@...>
Date: 2018-09-12T11:10:17Z
[ZEPPELIN-3773] - add permission check. Disable edit.
----
---
[GitHub] zeppelin issue #3179: [ZEPPELIN-3773] - add check permission on write.
Posted by mebelousov <gi...@git.apache.org>.
Github user mebelousov commented on the issue:
https://github.com/apache/zeppelin/pull/3179
@Savalek
You're right. I fix my shiro.ini.
But I still see a huge amount of background queries (up to 100 per second) connected with Helium.
I can reproduce the issue in development mode.
Tested on Ubuntu 16.04, Chromium (Version 69.0.3497.92) and Firefox Quantum 62.0
Check please.
---
[GitHub] zeppelin issue #3179: [ZEPPELIN-3773] - add check permission on write.
Posted by Savalek <gi...@git.apache.org>.
Github user Savalek commented on the issue:
https://github.com/apache/zeppelin/pull/3179
@mebelousov, Perhaps you have incorrectly configured shiro.ini.
---
[GitHub] zeppelin issue #3179: [ZEPPELIN-3773] - add check permission on write.
Posted by mebelousov <gi...@git.apache.org>.
Github user mebelousov commented on the issue:
https://github.com/apache/zeppelin/pull/3179
@Savalek
I see an infinite number of GET request like http://localhost:8080/api/helium/suggest/2DMKVSPYC/20180807-154514_2063688624 with response "401 Unauthorized" is case if user don't have permission for write. Could you fix?
---
[GitHub] zeppelin issue #3179: [ZEPPELIN-3773] - add check permission on write.
Posted by deradam <gi...@git.apache.org>.
Github user deradam commented on the issue:
https://github.com/apache/zeppelin/pull/3179
This seems to be the bug that we are also facing currently. I have a notebook with some users that only have read permissions. These users receive an error message that the do not have the update permission on the notebook and therefore cannot open it.
Any estimate when this will be merged and released?
---
[GitHub] zeppelin issue #3179: [ZEPPELIN-3773] - add check permission on write.
Posted by Savalek <gi...@git.apache.org>.
Github user Savalek commented on the issue:
https://github.com/apache/zeppelin/pull/3179
Need someone else to check this PR. Because I could not reproduce this error.
---
[GitHub] zeppelin issue #3179: [ZEPPELIN-3773] - add check permission on write.
Posted by Savalek <gi...@git.apache.org>.
Github user Savalek commented on the issue:
https://github.com/apache/zeppelin/pull/3179
@felixcheung, there is already a check on the server. Due to some errors, a commit of the paragraph went to the server and an error occurred.
---