[GitHub] spark pull request: [SPARK-10931][PYSPARK][ML] PySpark ML Models s...

[sethah <gi...@git.apache.org>]

Github user sethah commented on the pull request:

    https://github.com/apache/spark/pull/10270#issuecomment-175302328
  
    This approach only copies shared params like `HasFeatureCol` through class inheritance. Parameters defined in the actual model itself are not copied, so this patch won't mimic the scala side exactly. For example, the `NaiveBayes` smoothing parameter is not copied to the Naive Bayes model. It seems like we should copy all params from estimator to model, not just shared ones. Doing so likely requires manually copying those parameters through the model constructor or similar approach. The other approach proposed by @jkbradley in [the jira](https://issues.apache.org/jira/browse/SPARK-10931) is to override `getattr` but has the problem of not generating docs.
    
    I like the latter approach but the lack of doc generation may be a deal breaker. cc @holdenk 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org